Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 0.39.0 RC0 to 0.39.0 #6725

Merged
merged 40 commits into from
Jul 20, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
dd6f8c8
client/keys/parse: honor config changes (#6340)
Jun 9, 2020
65b6030
Merge PR #6505: Backport v0.38.5: IAVL Bump (RC) & Pruning Refactor
alexanderbez Jun 26, 2020
f5b801b
Fix cl
alexanderbez Jun 26, 2020
0c3be9b
Fix cl
alexanderbez Jun 26, 2020
12ffeee
Merge PR #6551: Ethanfrey/fix trace flag
ethanfrey Jul 1, 2020
1e6431e
Merge PR #6552: Add sender info to bank transfer event
ethanfrey Jul 1, 2020
b933205
deps: bump IAVL to 0.14
alexanderbez Jul 6, 2020
ca08830
cl++
alexanderbez Jul 6, 2020
a15ca8e
Merge PR #6618: backport 0.39.0 (launchpad): cherry pick #5839
alexanderbez Jul 6, 2020
4bc422d
launchpad: bump tendermint to v0.33.6 (#6673)
fedekunze Jul 10, 2020
8ba2440
fix types.ChainAnteDecorators() panic (#5742) (#6669)
Jul 10, 2020
232e720
launchpad: register MsgFundCommunityPool to distribution codec (#6675)
fedekunze Jul 10, 2020
b7f9914
client: backport IBC additions (#6682)
fedekunze Jul 10, 2020
864c621
Save account for multi sending (#6674)
jgimeno Jul 10, 2020
807ea26
baseapp: fix sender events accumulation (#6683)
Jul 13, 2020
411150e
Merge branch 'release/v0.39.0' into launchpad/release/v0.39
Jul 13, 2020
3ebc29f
run go mod tidy
Jul 13, 2020
c6a88ca
add changelog line re: issue that was not included in v0.38.5
Jul 13, 2020
9320f96
Fix changelog
Jul 14, 2020
8feceb0
add release notes
Jul 14, 2020
f384592
update CODEOWNERS as per STABLE_RELEASES.md
Jul 14, 2020
c2108e8
Add milestone's URL
Jul 14, 2020
f63b2ac
Revert "update CODEOWNERS as per STABLE_RELEASES.md"
Jul 14, 2020
2bed712
fix typo
Jul 14, 2020
23f82ff
add example patch
Jul 14, 2020
f4ae40b
launchpad: backport account sequence stuck (#6721)
fedekunze Jul 14, 2020
a0fb47f
update release notes
Jul 14, 2020
c0fe624
make explicit that the regression is fixed in 0.39
Jul 14, 2020
ae4dcbc
Merge pull request #6707 from cosmos/launchpad/release/v0.39
Jul 15, 2020
270045e
update release notes
Jul 15, 2020
3e51ee8
Update CHANGELOG.md
Jul 15, 2020
98ff8a3
update release notes
Jul 15, 2020
bb71483
remove pruning info from changelog
Jul 15, 2020
d7df1ef
Update NEWS.md
Jul 15, 2020
c251361
Mege PR #6749: auth: remove custom JSON marshaling
alexanderbez Jul 16, 2020
2f779e1
mv NEWS.md -> RELEASE_NOTES.md
Jul 16, 2020
ab3254f
Update changelog
Jul 16, 2020
04267dd
add reference to gaia software upgrade
Jul 17, 2020
e42c50c
x/staking: add call to iterator Close() method (#6794)
Jul 20, 2020
4bae3e8
[ci] fix linter (#6795)
Jul 20, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
x/staking: add call to iterator Close() method (#6794)
Original pull request: #6791
  • Loading branch information
Alessio Treglia authored Jul 20, 2020
commit e42c50c12344168c36296e7d0f3493822ce6fce2
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
* (client) [\#5585](https://github.com/cosmos/cosmos-sdk/pull/5585) `CLIContext` additions:
* Introduce `QueryABCI` that returns the full `abci.ResponseQuery` with inclusion Merkle proofs.
* Added `prove` flag for Merkle proof verification.
* (x/staking) [\#6791)](https://github.com/cosmos/cosmos-sdk/pull/6791) Close {UBDQueue,RedelegationQueu}Iterator once used.

### API Breaking Changes

Expand Down
4 changes: 4 additions & 0 deletions x/staking/keeper/delegation.go
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,8 @@ func (k Keeper) DequeueAllMatureUBDQueue(ctx sdk.Context,
store := ctx.KVStore(k.storeKey)
// gets an iterator for all timeslices from time 0 until the current Blockheader time
unbondingTimesliceIterator := k.UBDQueueIterator(ctx, ctx.BlockHeader().Time)
defer unbondingTimesliceIterator.Close()

for ; unbondingTimesliceIterator.Valid(); unbondingTimesliceIterator.Next() {
timeslice := []types.DVPair{}
value := unbondingTimesliceIterator.Value()
Expand Down Expand Up @@ -445,6 +447,8 @@ func (k Keeper) DequeueAllMatureRedelegationQueue(ctx sdk.Context, currTime time
store := ctx.KVStore(k.storeKey)
// gets an iterator for all timeslices from time 0 until the current Blockheader time
redelegationTimesliceIterator := k.RedelegationQueueIterator(ctx, ctx.BlockHeader().Time)
defer redelegationTimesliceIterator.Close()

for ; redelegationTimesliceIterator.Valid(); redelegationTimesliceIterator.Next() {
timeslice := []types.DVVTriplet{}
value := redelegationTimesliceIterator.Value()
Expand Down