Release v0.39.0 - RC0 #6707

alessio · 2020-07-13T18:35:15Z

Launchpad v0.39.0

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer
Review Codecov Report in the comment section below once CI passes

`keys parse` uses the global configuration before before client applications have had a chance to apply their settings. This change adds a `GetSealedConfig()` helper that waits for the config to be sealed before returning it. Fixes: #5091 Origin: 4e328d7 Author: Adam Bozanich <adam.boz@gmail.com> Reviewed-by: Alessio Treglia <alessio@tendermint.com>

* launchpad: bump tendermint to v0.33.6 * cha-cha-cha

ChainAnteDecorators() panics when no arguments are supplied. This change its behaviour and the function now returns a nil AnteHandler in case no AnteDecorator instances are supplied. Closes: #5741

Closes: #6210

* launchpad: backport cliCtx.QueryABCI * add prove flag

Include changes from PR #6283 Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Alessio Treglia <alessio@tendermint.com>

closes: #6306 original PR: #6307

tac0turtle · 2020-07-13T18:41:53Z

Does this need a testnet to do testnet before release?

alessio · 2020-07-13T18:54:29Z

@marbar3778 dixit:

Does this need a testnet to do testnet before release?

I would agree to that, yes.

codecov · 2020-07-13T19:07:17Z

Codecov Report

❗ No coverage uploaded for pull request base (release/v0.39.0@5f6e499). Click here to learn what that means.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##             release/v0.39.0    #6707   +/-   ##
==================================================
  Coverage                   ?   51.60%           
==================================================
  Files                      ?      337           
  Lines                      ?    20643           
  Branches                   ?        0           
==================================================
  Hits                       ?    10653           
  Misses                     ?     9182           
  Partials                   ?      808

go.sum

@okwme

Launchpad's Stable Release Managers team's current composition as approved by @okwme (ICF): * @alessio * @clevinson * @ethanfrey

tac0turtle · 2020-07-14T10:35:17Z

.github/CODEOWNERS

@@ -1,7 +1,7 @@
 # CODEOWNERS: https://help.github.com/articles/about-codeowners/

 # Primary repo maintainers
-*       @rigelrozanski @alexanderbez @jackzampolin @alessio @fedekunze
+*       @alessio @clevinson @ethanfrey


I don't believe this does what you would like. You should set these codeowners to the 0.39 line. so you three would be code owners for the backport branches only.

This won't change anything as the codeowners need to be on the default branch...

https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners#codeowners-file-location

I originally intended to use the CODEOWNERShip thingy as a way to automatically notify the people listed there on PRs that was meant to be merged against launchpad-specific branches (cause when you are in CODEOWNERS you get the notification automatically every time a PR is opened). But I think you're right, maybe this is not the best way of doing it - and it's not effective at all either. Can you help me please?

(meanwhile, I've reverted the respective commit)

This reverts commit f384592.

Launchpad fix for #6287

clevinson

Minor comment on release notes, otherwise looks good!

clevinson · 2020-07-14T20:58:44Z

NEWS.md

+
+## Regression in the signature verification when multiple transactions in the same block are sent from the same account
+
+When multiple transactions in the same block are sent (and correctly signed) by the same account, chances are that some of them could be rejected and the error `unauthorized: signature verification failed` would be returned due to the account's sequence (*nonce*) getting stuck and not being incremented by the ante handler. This behaviour was [a regression](https://github.com/cosmos/cosmos-sdk/issues/6287) introduced in the `v0.38` release series and did not occur in the `v0.37` release series.


Could we be more explicit in this section that the regression has been fixed in 0.39? This section currently outlines the problem, but does not really state whether or not it has been fixed in 0.39.

Good point, please see c0fe624

Alessio Treglia and others added 15 commits June 9, 2020 15:46

Merge PR #6505: Backport v0.38.5: IAVL Bump (RC) & Pruning Refactor

65b6030

Fix cl

f5b801b

Fix cl

0c3be9b

Merge PR #6551: Ethanfrey/fix trace flag

12ffeee

Merge PR #6552: Add sender info to bank transfer event

1e6431e

deps: bump IAVL to 0.14

b933205

cl++

ca08830

Merge PR #6618: backport 0.39.0 (launchpad): cherry pick #5839

a15ca8e

launchpad: bump tendermint to v0.33.6 (#6673)

4bc422d

* launchpad: bump tendermint to v0.33.6 * cha-cha-cha

fix types.ChainAnteDecorators() panic (#5742) (#6669)

8ba2440

ChainAnteDecorators() panics when no arguments are supplied. This change its behaviour and the function now returns a nil AnteHandler in case no AnteDecorator instances are supplied. Closes: #5741

launchpad: register MsgFundCommunityPool to distribution codec (#6675)

232e720

Closes: #6210

client: backport IBC additions (#6682)

b7f9914

* launchpad: backport cliCtx.QueryABCI * add prove flag

Save account for multi sending (#6674)

864c621

Include changes from PR #6283 Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Alessio Treglia <alessio@tendermint.com>

baseapp: fix sender events accumulation (#6683)

807ea26

closes: #6306 original PR: #6307

Alessio Treglia added 2 commits July 13, 2020 19:51

Merge branch 'release/v0.39.0' into launchpad/release/v0.39

411150e

run go mod tidy

3ebc29f

fedekunze reviewed Jul 13, 2020

View reviewed changes

go.sum Show resolved Hide resolved

fedekunze approved these changes Jul 13, 2020

View reviewed changes

Alessio Treglia added 5 commits July 14, 2020 00:14

add changelog line re: issue that was not included in v0.38.5

c6a88ca

Fix changelog

9320f96

add release notes

8feceb0

update CODEOWNERS as per STABLE_RELEASES.md

f384592

Launchpad's Stable Release Managers team's current composition as approved by @okwme (ICF): * @alessio * @clevinson * @ethanfrey

Add milestone's URL

c2108e8

tac0turtle reviewed Jul 14, 2020

View reviewed changes

Alessio Treglia added 2 commits July 14, 2020 11:50

Revert "update CODEOWNERS as per STABLE_RELEASES.md"

f63b2ac

This reverts commit f384592.

fix typo

2bed712

alessio requested a review from clevinson July 14, 2020 14:43

Alessio Treglia and others added 2 commits July 14, 2020 17:47

add example patch

23f82ff

launchpad: backport account sequence stuck (#6721)

f4ae40b

Launchpad fix for #6287

alessio marked this pull request as ready for review July 14, 2020 17:25

alessio requested review from alexanderbez and jackzampolin as code owners July 14, 2020 17:25

alessio marked this pull request as draft July 14, 2020 17:29

update release notes

a0fb47f

clevinson reviewed Jul 14, 2020

View reviewed changes

make explicit that the regression is fixed in 0.39

c0fe624

alessio changed the base branch from release/v0.39.0 to rc0/v0.39.0 July 15, 2020 10:46

alessio changed the title ~~Release v0.39.0~~ Release v0.39.0 - RC0 Jul 15, 2020

alessio marked this pull request as ready for review July 15, 2020 10:47

alessio merged commit ae4dcbc into rc0/v0.39.0 Jul 15, 2020

alessio deleted the launchpad/release/v0.39 branch July 15, 2020 10:49

alessio mentioned this pull request Jul 15, 2020

Migrate to Cosmos-SDK 0.39.0-rc akash-network/node#747

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release v0.39.0 - RC0 #6707

Release v0.39.0 - RC0 #6707

alessio commented Jul 13, 2020

tac0turtle commented Jul 13, 2020 •

edited

Loading

alessio commented Jul 13, 2020

codecov bot commented Jul 13, 2020 •

edited

Loading

tac0turtle Jul 14, 2020 •

edited

Loading

alessio Jul 14, 2020 •

edited

Loading

alessio Jul 14, 2020

clevinson left a comment

clevinson Jul 14, 2020 •

edited

Loading

alessio Jul 14, 2020


		## Regression in the signature verification when multiple transactions in the same block are sent from the same account

		When multiple transactions in the same block are sent (and correctly signed) by the same account, chances are that some of them could be rejected and the error `unauthorized: signature verification failed` would be returned due to the account's sequence (nonce) getting stuck and not being incremented by the ante handler. This behaviour was [a regression](https://github.com/cosmos/cosmos-sdk/issues/6287) introduced in the `v0.38` release series and did not occur in the `v0.37` release series.

Release v0.39.0 - RC0 #6707

Release v0.39.0 - RC0 #6707

Conversation

alessio commented Jul 13, 2020

tac0turtle commented Jul 13, 2020 • edited Loading

alessio commented Jul 13, 2020

codecov bot commented Jul 13, 2020 • edited Loading

Codecov Report

tac0turtle Jul 14, 2020 • edited Loading

Choose a reason for hiding this comment

alessio Jul 14, 2020 • edited Loading

Choose a reason for hiding this comment

alessio Jul 14, 2020

Choose a reason for hiding this comment

clevinson left a comment

Choose a reason for hiding this comment

clevinson Jul 14, 2020 • edited Loading

Choose a reason for hiding this comment

alessio Jul 14, 2020

Choose a reason for hiding this comment

tac0turtle commented Jul 13, 2020 •

edited

Loading

codecov bot commented Jul 13, 2020 •

edited

Loading

tac0turtle Jul 14, 2020 •

edited

Loading

alessio Jul 14, 2020 •

edited

Loading

clevinson Jul 14, 2020 •

edited

Loading