WIP: expose historical queries #258

ethanfrey · 2017-10-19T13:29:22Z

This is based on PR #257 and should not be merged until that PR gets merged to develop, thus the WIP state. Beside the dependency, the code is ready to merge IMO.

We now keep the last 10 blocks available for queries and expose the height as an argument for queries. If H is the last committed block, the default (height=0) is to return H-1, as you can immediately get a proof for this. (Most recent query with proofs). If you just submitted a tx that was included on height H, you should query with --height=$H in order to ensure you read the state after the tx was processed.

This involved updating all the shell script integration tests, which do just this, send a tx, then immediately query the state.

cloudhead · 2017-10-19T15:07:03Z

client/query.go

cloudhead · 2017-10-19T15:22:59Z

genesis/parse.go

If you do make([]Option, 0, cnt) then you can use append and don't need to have an i variable, and it's the same speed.

cloudhead · 2017-10-19T15:29:39Z

state/merkle.go

I wrote this, but I don't like it that much - it doesn't communicate the intent very well. I wonder if we should have a method inside Tree that is more descriptive, like tree.IsEmpty()

Yes, please do. So we can quickly check if we can save safely

Added IsEmpty to develop. You should be able to replace that with !s.committed.Tree.IsEmpty()

We only really need to check the Size actually, since if the latest version is > 0, then there are keys in the tree, but I'd still recommend using the new !IsEmpty.

cloudhead · 2017-10-19T15:30:43Z

state/merkle.go

Nice poor-man's pruning!

Yup, hardcoded length, enough to get it out. We can work on other techniques later, but refactoring will change a lot, so it can wait.

melekes · 2017-10-19T14:55:34Z

app/app_test.go

require.NoError?

Actually, here I require it is an error

You can do require.Error then :)

melekes · 2017-10-19T15:43:41Z

genesis/parse.go

maybe it's worth to make / a const? like KeyDelimiter

yes, did that

StoreApp just the queries, BaseApp with handler/ticker Ticker now defined top level, as an interface, with context Name for info taken as parameter, start cmd uses commandline name Cleaner compisition of apps.

…ter godoc

* Rebuild PDF * Separate commitment path (ref cosmos#258) * Clarify connection versioning (ref cosmos#269) * Note private store key flexibility (ref cosmos#145)

…osmos#258) Solution: - add API NewFromParent to cache multistore. Update store/CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> fix test fix lint

* [cosmos#207](crypto-org-chain#207) Remove api CacheWrapWithTrace. * [cosmos#205](crypto-org-chain#205) Support object store. * [cosmos#240](crypto-org-chain#240) Split methods from `MultiStore` into specialized `RootMultiStore`, keep `MultiStore` generic. * [cosmos#241](crypto-org-chain#241) Refactor the cache store to be btree backed, prepare to support copy-on-write atomic branching. * [cosmos#242](crypto-org-chain#242) Init cache on cache lazily, save memory allocations. * [cosmos#243](crypto-org-chain#243) Support `RunAtomic` API to use new CoW cache store. * [cosmos#244](crypto-org-chain#244) Add `Discard` method to CacheWrap to discard the write buffer. * [cosmos#258](crypto-org-chain#258) Add `NewFromParent` API to cachemulti store to create a new store from block-stm multiversion data structure. * [cosmos#1043](crypto-org-chain#1043) Add back CacheWrapWithTrace api.

…258) Solution: - add API NewFromParent to cache multistore. Update store/CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> fix test fix lint

cloudhead reviewed Oct 19, 2017

View reviewed changes

client/query.go Outdated

Copy link

Contributor

cloudhead Oct 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

cloudhead reviewed Oct 19, 2017

View reviewed changes

melekes reviewed Oct 19, 2017

View reviewed changes

ethanfrey added 25 commits October 20, 2017 13:42

Started separating BaseApp from Basecoin

e863e1b

Pull out basecoin stuff

987c046

Merged app.Store into app.BaseApp

9d1205f

Fixed all tests

c1d36ee

Separate genesis parsing from basecoin

df0f3a2

Cleanup

adab86c

Clean up genesis handling

3a16fa9

Big cleanup of app dir

f65215a

StoreApp just the queries, BaseApp with handler/ticker Ticker now defined top level, as an interface, with context Name for info taken as parameter, start cmd uses commandline name Cleaner compisition of apps.

Abort on error with genesis app_options

3316bfc

Eyes takes init state, fix cli test about genesis

9b20615

StoreApp explicitly exposes some State methods, not embedded, for bet…

4855b3c

…ter godoc

Clean up state.State as we only support persistence

fbe88ee

Pulled genesis file parsing into own package, for clarity

6305399

Cleanup names in genesis package

7631680

Clean up genesis, add godoc to genesis and app

acdc083

Update deps: tendermint/abci/iavl, fix code

418c657

Clean up store versions after a limit

91f8e35

Expose height flag in all queries

10764bb

Handle explicit heights to query tx in basictx.sh

530e9b4

Fix cli tests to explicitly pass height when querying results of tx

d77a41d

Fixed height handling in rest queries

a431861

Fix up some ibc queries, debug height mismatch

9f777b4

Fix IBC off-by-one with proofs

8460c9c

Better tests on ibc packet receipt, clean up shell test

44b63e8

Update ibc unit tests for height+1

bd20a6e

ethanfrey added 3 commits October 20, 2017 13:42

update abci, iavl, tendermint versions again

f3f5a3b

Cleanup loop per Alexis

f4a7fc0

Clean up genesis parse per Anton

7ef20bb

ethanfrey force-pushed the feature/expose-historical-queries branch from 6747314 to 7ef20bb Compare October 20, 2017 11:46

ethanfrey added 2 commits October 20, 2017 19:41

Update iavl tree and address pr cleanup comments

ae4a1ba

Dpes use develop, now that abci and light client prs are merged

e61e7af

ethanfrey merged commit e61e7af into develop Oct 24, 2017

ethanfrey mentioned this pull request Oct 24, 2017

expose historical queries #267

Merged

catShaark referenced this pull request in notional-labs/cosmos-sdk Jun 11, 2022

feat: support indexing denom metadata denom units (#258)

e00a3eb

WIP: expose historical queries #258

WIP: expose historical queries #258

Uh oh!

Conversation

ethanfrey commented Oct 19, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ethanfrey commented Oct 19, 2017 •

edited

Loading