expose historical queries #267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Replaces #258 which accidentally got merged before time |
ethanfrey
force-pushed
the
feature/expose-historical-queries
branch
from
e61e7af to
ae09c8f
Compare
catShaark
referenced
this pull request
in notional-labs/cosmos-sdk
Jun 29, 2022
brendan-kelly
referenced
this pull request
in figment-networks/cosmos-sdk
Aug 3, 2022
* is gen test * my attempt at isGenesis * logs and uncomment * more changes * comment out * change init gen call loc * further gen tests * more tests * another test * revert unneeded changes * remove extra * reset to false * Update x/auth/ante/sigverify.go Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * changes from call with bez Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on PR #257 and should not be merged until that PR gets merged to develop, thus the WIP state. Beside the dependency, the code is ready to merge IMO.
We now keep the last 10 blocks available for queries and expose the height as an argument for queries. If H is the last committed block, the default (height=0) is to return H-1, as you can immediately get a proof for this. (Most recent query with proofs). If you just submitted a tx that was included on height H, you should query with --height=$H in order to ensure you read the state after the tx was processed.
This involved updating all the shell script integration tests, which do just this, send a tx, then immediately query the state.