Skip to content

Conversation

@yihuang
Copy link

@yihuang yihuang commented Mar 23, 2024

Solution:

  • remove the api

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@yihuang yihuang requested a review from mmsqe March 23, 2024 09:10
Copy link

@mmsqe mmsqe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just not sure if need replace cosmossdk.io/store => ./store

@yihuang
Copy link
Author

yihuang commented Mar 24, 2024

just not sure if need replace cosmossdk.io/store => ./store

we can do dependees and dependers in different PRs I suppose.

Solution:
- remove the api

changelog
@yihuang yihuang force-pushed the remove-cachewrapwithtrace branch from 5325279 to d7eebff Compare March 25, 2024 01:26
@yihuang yihuang enabled auto-merge (squash) March 25, 2024 01:32
@yihuang yihuang merged commit 56cb96c into crypto-org-chain:release/v0.50.x Mar 25, 2024
@yihuang yihuang deleted the remove-cachewrapwithtrace branch March 25, 2024 01:39
mmsqe added a commit that referenced this pull request Jan 16, 2025
* Revert "Problem: CacheWrapWithTrace api is not used (#207)"

This reverts commit 56cb96c.

* resolve

* cleanup

* fix cyclic dependency

* fix test

* better equavalence

---------

Co-authored-by: HuangYi <huang@crypto.com>
maxim-inj added a commit to InjectiveLabs/cosmos-sdk that referenced this pull request May 4, 2025
* [cosmos#207](crypto-org-chain#207) Remove api CacheWrapWithTrace.
* [cosmos#205](crypto-org-chain#205) Support object store.
* [cosmos#240](crypto-org-chain#240) Split methods from `MultiStore` into specialized `RootMultiStore`, keep `MultiStore` generic.
* [cosmos#241](crypto-org-chain#241) Refactor the cache store to be btree backed, prepare to support copy-on-write atomic branching.
* [cosmos#242](crypto-org-chain#242) Init cache on cache lazily, save memory allocations.
* [cosmos#243](crypto-org-chain#243) Support `RunAtomic` API to use new CoW cache store.
* [cosmos#244](crypto-org-chain#244) Add `Discard` method to CacheWrap to discard the write buffer.
* [cosmos#258](crypto-org-chain#258) Add `NewFromParent` API to cachemulti store to create a new store from block-stm multiversion data structure.
* [cosmos#1043](crypto-org-chain#1043) Add back CacheWrapWithTrace api.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants