-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notice if a filesystem overwrites a partitioned disk #1397
Comments
I'm wondering if we should even do this warning at the Ignition level (which I think butane also surfaces Ignition warnings). That means the user would actually get the warning on the console because of our recent addition in coreos/fedora-coreos-config#1621 |
Actually, yeah, that's a good point. I'll leave this issue here for now so other people can weigh in, but if there's consensus we can move it over to Ignition. |
This seems relevant to any distro using Ignition, so having this in Ignition directly SGTM! |
Moved to Ignition. |
Shouldn't this be:
? (And the sample Butane config updated accordingly.) I guess we could check also that |
@jlebon Whoops, yes, good catch. 😖 Also, we should probably only warn if there are any As a further refinement, we could warn if |
Fixes coreos#1397, a common configuration error is to create a filesystem over a whole-disk device rather than a partition. Add a warning for a filesystem device matching the disk device. Additionally, another configuration error was identified for a way to recreate the filesystem on every provision, while the configuration to do so is valid, it might be done unitionally. Add a warning when wipeTable is true but wipeFilesystem is false.
Fixes coreos#1397, a common configuration error is to create a filesystem over a whole-disk device rather than a partition. Add a warning for a filesystem device matching the disk device. Additionally, another configuration error was identified for a way to recreate the filesystem on every provision, while the configuration to do so is valid, it might be done unitionally. Add a warning when wipeTable is true but wipeFilesystem is false.
Fixes coreos#1397, a common configuration error is to create a filesystem over a whole-disk device rather than a partition. Add a warning for a filesystem device matching the disk device. Additionally, another configuration error was identified for a way to recreate the filesystem on every provision, while the configuration to do so is valid, it might be done unitionally. Add a warning when wipeTable is true but wipeFilesystem is false.
Fixes coreos#1397, a common configuration error is to create a filesystem over a whole-disk device rather than a partition. Add a warning for a filesystem device matching the disk device. Additionally, another configuration error was identified for a way to recreate the filesystem on every provision, while the configuration to do so is valid, it might be done unitionally. Add a warning when wipeTable is true but wipeFilesystem is false.
Fixes coreos#1397, a common configuration error is to create a filesystem over a whole-disk device rather than a partition. Add a warning for a filesystem device matching the disk device. Additionally, another configuration error was identified for a way to recreate the filesystem on every provision, while the configuration to do so is valid, it might be done unitionally. Add a warning when wipeTable is true but wipeFilesystem is false.
Fixes coreos#1397, a common configuration error is to create a filesystem over a whole-disk device rather than a partition. Add a warning for a filesystem device matching the disk device. Additionally, another configuration error was identified for a way to recreate the filesystem on every provision, while the configuration to do so is valid, it might be done unitionally. Add a warning when wipeTable is true but wipeFilesystem is false.
A common configuration error is to create a filesystem over a whole-disk device rather than the partition that was intended:
Add a warning if a
storage.filesystems.device
matches astorage.disks.device
.The text was updated successfully, but these errors were encountered: