-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn if the root filesystem is too small #211
Comments
We've decided to defer this until we have coreos/fedora-coreos-tracker#759 because otherwise it's impossible in many cases for Butane to know that it's looking at the root disk. There are some cases where it could (e.g. if root reprovisioning/mirroring is requested), but the common case of just adding a "trapping partition" wouldn't be detectable without some dubious heuristics. |
@bgilbert This issue might belong in ignition? Similar to coreos/ignition#1397 (comment) |
Ignition is distro-independent and doesn't know the partition layout constraints of the OS it runs on, so this needs to go in Butane in the |
Darn, ok thank you! |
I wanted to ask a clarifying question, do we consider root constrained if there is a partition in front of it aka /var on number 5 ? or is it only constrained if the underlying storage is explicitly specified and there is a partition in front of it ? In speaking with @jlebon it is fairly common ask to have a /var partition after root for us, and I was unsure if we wanted a warning in a common configuration case. |
It's common to have a
|
Fixes coreos#211 , add warning for under allocation of root partition. additionally add warning when root partition's expansion is constrained
Fixes coreos#211, the root partition needs a certain amount of space, with recent changes butane has the opportunity to warn when those expectations are not met. Add a warn when the root is too small, and additionally add warn when the root is small and cannot expand.
Add a warning if the root filesystem is too small (coreos/fedora-coreos-tracker#586), either because the underlying storage is explicitly specified, or because the root partition is constrained by an additional partition.
The text was updated successfully, but these errors were encountered: