-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
05core/*: display Ignition warnings on the console #1621
05core/*: display Ignition warnings on the console #1621
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit message mentions the serial console but this is misleading; the MOTD is shown on the graphical console too.
overlay.d/05core/usr/libexec/coreos-ignition-display-debug-info
Outdated
Show resolved
Hide resolved
overlay.d/05core/usr/libexec/coreos-ignition-display-debug-info
Outdated
Show resolved
Hide resolved
overlay.d/05core/usr/libexec/coreos-ignition-display-debug-info
Outdated
Show resolved
Hide resolved
overlay.d/05core/usr/libexec/coreos-ignition-display-debug-info
Outdated
Show resolved
Hide resolved
overlay.d/05core/usr/libexec/coreos-ignition-display-debug-info
Outdated
Show resolved
Hide resolved
overlay.d/05core/usr/lib/systemd/system/coreos-ignition-display-debug-info.service
Outdated
Show resolved
Hide resolved
b8de010
to
c2d7295
Compare
overlay.d/05core/usr/lib/systemd/system/coreos-ignition-status-info.service
Outdated
Show resolved
Hide resolved
c2d7295
to
9436e96
Compare
overlay.d/05core/usr/lib/systemd/system/coreos-ignition-status-info.service
Outdated
Show resolved
Hide resolved
overlay.d/05core/usr/lib/systemd/system/coreos-ignition-status-info.service
Outdated
Show resolved
Hide resolved
4a90aaa
to
16f2a39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good generally. A couple bugs, and a couple things I hadn't noticed earlier.
overlay.d/05core/usr/lib/systemd/system-preset/40-coreos.preset
Outdated
Show resolved
Hide resolved
7b14e35
to
aef2d54
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments but LGTM as is too. Nice work!
I think it wouldn't be too hard to write an external test for this, right? E.g. a test with an Ignition config that we know generates a warning and verify that an issue file with the expected content is created.
overlay.d/05core/usr/lib/systemd/system-preset/40-coreos.preset
Outdated
Show resolved
Hide resolved
aef2d54
to
8c6c52f
Compare
Yeah, I will do this as a follow-up PR, sounds good? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, SGTM!
Fixes coreos/fedora-coreos-tracker#1125 This change displays all Ignition warnings on the console. Also, renamed the existing Ignition service to make it more generalized for handling status information about the Ignition run.
8c6c52f
to
9b35aab
Compare
Nice work @sohankunkerkar |
Follow up to coreos#1621 (review) This adds kola test coverage for displaying Ignition warnings on the console.
Follow up to coreos#1621 (review) This adds kola test coverage for displaying Ignition warnings on the console.
Follow up to coreos#1621 (review) This adds kola test coverage for displaying Ignition warnings on the console.
Follow up to coreos#1621 (review) This adds kola test coverage for displaying Ignition warnings on the console.
Follow up to coreos#1621 (review) This adds kola test coverage for displaying Ignition warnings on the console.
Follow up to coreos#1621 (review) This adds kola test coverage for displaying Ignition warnings on the console.
Follow up to coreos#1621 (review) This adds kola test coverage for displaying Ignition warnings on the console.
Follow up to coreos#1621 (review) This adds kola test coverage for displaying Ignition warnings on the console.
Follow up to #1621 (review) This adds kola test coverage for displaying Ignition warnings on the console.
Follow up to coreos#1621 (review) This adds kola test coverage for displaying Ignition warnings on the console.
Follow up to coreos#1621 (review) This adds kola test coverage for displaying Ignition warnings on the console.
Fixes coreos/fedora-coreos-tracker#1125
This change displays all Ignition warnings on the console. Also, renamed the existing Ignition service to make it more generalized for handling status information about the Ignition run