Release January 2018 / 1 #303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This duplicates the UsersController#give_time to TransferController#new as it should be by Rails conventions. We aim to stick to REST conventions of the Transfer resource instead of having custom actions on users and organizations controllers.
This duplicates the OrganizationsController#give_time to TransferController#new as it should be by Rails conventions. We aim to stick to REST conventions of the Transfer resource instead of having custom actions on users and organizations controllers.
This is slowly turning "turning difference into sameness" following Sandi Metz style.
By specifying the account id we can abstract away from User or Organization objects and trust just the account. As a result, this removes ifs and therefore complexity.
Then each particular view knows what type the accountable has and uses the appropriate methods like user_path or organization_path.
This makes the controller specs integration-like enough to ensure things keep working when we later refactor the views and the controller ivars.
Now transfers/new.html.erb and transfers/new_organization.html.erb are identical. All their differences were moved to partials as if we extracted abstract methods in a class and moved the conditionals within them.
Now there's no point on using one for user/member and another one for organization.
…no longer present
…ive organization and it can’t be queried directly from the database
Provides a name to the action_item added to have the "Upload CSV" button as speciied by ActiveAdmin docs.
Fix activeadmin's deprecation warning
Remove dead #languages_list helper
It extracts compound conditionals, adds some doc and emphasizes problems that arise from the current implementation such as the fact that max_allowed_balance it's either Integer or Float.
Improve update balance
https://github.com/heroku/rails_12factor install instructions clearly state that this should go into the :production group in the Gemfile.
You can install in your dev system if you want. No need to add the extra maintainability cost to keep the dependency up to date.
According to its docs, "DEPRECATED: Use `travis lint` (from travis gem) instead". Also, "there's also an online version of this tool at lint.travis-ci.org."
As stated in its docs, it should go in those groups. It's not meant to be used in production.
No need for a comment. This is what git is for. To keep track of changes.
This removes the scroll bar that shows up in the users list, which you can't move at all.
Fix/tags order
…ers-controller Move give time action to transfers controller
Refactor Users#index to paginate and filter on the backend. Closes #266
Upgrade to rails 4.2.7.1
Cleanup gemfile
This attribute belongs to another model, so Rails couldn't find its translation.
Fix translations not being picked up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a new release that includes the following changes:
The PRs that introduced said changes are: #241, #264, #272, #283, #294, #302