Skip to content

Fix activeadmin's deprecation warning #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2018

Conversation

sauloperez
Copy link
Collaborator

@sauloperez sauloperez commented Jan 15, 2018

Provides a name to the action_item added to have the "Upload CSV"
button as specified by ActiveAdmin docs. (See https://activeadmin.info/8-custom-actions.html#action-items)

Before:

➜  timeoverflow (remove-activeadmin-warning) b rails s
warning: parser/current is loading parser/ruby22, which recognizes                                                                          warning: 2.2-compliant syntax, but you are running 2.3.0.                                                                                   
=> Booting Thin                                                                                                                             
=> Rails 4.2.5.2 application starting in development on http://localhost:3000                                                               
=> Run `rails server -h` for more startup options                                                                                           
=> Ctrl-C to shutdown server                                                                                                                
DEPRECATION WARNING: Active Admin: using `action_item` without a name is deprecated! Use `action_item(:edit)`. (called from action_item at /
home/pau/dev/timeoverflow/vendor/bundle/ruby/2.3.0/bundler/gems/activeadmin-60914c887942/lib/active_admin/dsl.rb:92)                        
Thin web server (v1.6.3 codename Protein Powder)                                                                         
Maximum connections set to 1024                                                                                                             
Listening on localhost:3000, CTRL+C to stop  

Now:

➜  timeoverflow (remove-activeadmin-warning) ADMINS=admin@timeoverflow.org b rails s                                                    ✭ ✱
warning: parser/current is loading parser/ruby22, which recognizes
warning: 2.2-compliant syntax, but you are running 2.3.0.                                                                                   => Booting Thin                                           
=> Rails 4.2.5.2 application starting in development on http://localhost:3000                                                               => Run `rails server -h` for more startup options                                                     
=> Ctrl-C to shutdown server                                                                                                                
Thin web server (v1.6.3 codename Protein Powder)                                                      
Maximum connections set to 1024                                                                                                             
Listening on localhost:3000, CTRL+C to stop          

The deprecation warning is gone and the button is still there:

users

Provides a name to the action_item added to have the "Upload CSV"
button as speciied by ActiveAdmin docs.
@sauloperez sauloperez merged commit 74bde75 into develop Jan 15, 2018
@sauloperez sauloperez deleted the remove-activeadmin-warning branch January 15, 2018 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants