Skip to content

Remove dead #languages_list helper #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2018
Merged

Remove dead #languages_list helper #290

merged 1 commit into from
Jan 18, 2018

Conversation

sauloperez
Copy link
Collaborator

@sauloperez sauloperez commented Jan 16, 2018 •
edited
Loading

It was introduced in eb78969 and used in the _navbar but it became dead in 0fecd89 when the navbar was refactored.

Now we use I18n.available_locales.

@sauloperez
Remove dead #languages_list helper
7a564c0 
It was introduced in eb78969 and used
in the _navbar but it became dead in
0fecd89 when the navbar was refactored.

Now we use `I18n.available_locales`.
@sauloperez
Copy link
Collaborator Author

Tested and all languages fully working 🎉

@sauloperez sauloperez merged commit fe87533 into develop Jan 18, 2018
@sauloperez sauloperez deleted the remove-dead-helper branch January 18, 2018 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enricostano enricostano enricostano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sauloperez @enricostano