-
Notifications
You must be signed in to change notification settings - Fork 915
Rebuild the package with wheel instead of zip for correct signatures. #896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It looks like @lexn82 hasn't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here. Once you've signed reply with Appreciation of efforts, clabot |
[clabot:check] |
@confluentinc It looks like @lexn82 just signed our Contributor License Agreement. 👍 Always at your service, clabot |
Looks like the It turns out there is an even easier way to package a directory with wheel using CLI. I updated the PR accordingly. |
Superb, thank you! |
Fixes issue-482.
Instead of re-zipping the files after fixing up binaries, we use the
WheelFile
frombdist_wheel
package to rebuild the wheel properly.This works as-is if the wheel package is available to the system python interpreter, otherwise we may need a little more scripting to setup venv and
pip install wheel
.