Skip to content

Rebuild the package with wheel instead of zip for correct signatures. #896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 9, 2020

Conversation

anikifoss
Copy link
Contributor

@anikifoss anikifoss commented Jun 12, 2020

Fixes issue-482.

Instead of re-zipping the files after fixing up binaries, we use the WheelFile from bdist_wheel package to rebuild the wheel properly.

This works as-is if the wheel package is available to the system python interpreter, otherwise we may need a little more scripting to setup venv and pip install wheel.

@ghost
Copy link

ghost commented Jun 12, 2020

It looks like @lexn82 hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

@anikifoss
Copy link
Contributor Author

[clabot:check]

@ghost
Copy link

ghost commented Jun 12, 2020

@confluentinc It looks like @lexn82 just signed our Contributor License Agreement. 👍

Always at your service,

clabot

@anikifoss
Copy link
Contributor Author

anikifoss commented Jul 8, 2020

Looks like the wheel package is not intended to be used as a library so it does not provide a stable API (see docs here).

It turns out there is an even easier way to package a directory with wheel using CLI. I updated the PR accordingly.

@anikifoss anikifoss requested a review from edenhill July 8, 2020 20:57
@edenhill
Copy link
Contributor

edenhill commented Jul 8, 2020

Superb, thank you!

@edenhill edenhill merged commit dc2033a into confluentinc:master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PyPI wheel for 0.11.6 (Python 3.6 x86-64, manylinux) causes BadWheelFile
2 participants