Skip to content

Rebuild the package with wheel instead of zip for correct signatures. #896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 9, 2020
Merged

Rebuild the package with wheel instead of zip for correct signatures. #896

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4b881f6
Rebuild the package with wheel instead of zip for correct signatures.
Jun 12, 2020
dbba2f7
Moved wheel rebuilding script into a .py file.
Jun 23, 2020
70e4329
Invoke wheel from command line instead of a py script.
Jul 8, 2020
0a6b911
travis cibuildwheel: install wheel
edenhill Jul 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
# Install cibuildwheel if this is a tagged PR
before_install:
- if [[ $TRAVIS_OS_NAME == "osx" ]]; then tools/prepare-osx.sh ${INTERPRETER_VERSION} /tmp/venv && source /tmp/venv/bin/activate; fi
- if [[ -n $TRAVIS_TAG && -n $CIBW_BEFORE_BUILD ]]; then pip install cibuildwheel --force-reinstall; fi
- if [[ -n $TRAVIS_TAG && -n $CIBW_BEFORE_BUILD ]]; then pip install -r tools/requirements-manylinux.txt --force-reinstall; fi

# Install interceptors
# Install librdkafka if not CIBW_BEFORE_BUILD
Expand Down
8 changes: 3 additions & 5 deletions tools/fixup-wheels.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,10 @@ fixup_wheel () {
fixup_wheel_macosx
fi

zip -r $fixed_whl .

popd # tmpdir

wheel pack $tmpdir -d $fixed_wheelhouse

rm -rf $tmpdir

echo "Fixed $fixed_whl"
Expand Down Expand Up @@ -165,6 +166,3 @@ fi
for wheel in $wheelhouse/*${wheelmatch}*.whl ; do
fixup_wheel "$wheel"
done



1 change: 1 addition & 0 deletions tools/requirements-manylinux.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
cibuildwheel
wheel