Skip to content

Commit dc2033a

Browse files
anikifossedenhill
andauthored
Rebuild the package with wheel instead of zip for correct signatures. (#896)
* Rebuild the package with wheel instead of zip for correct signatures. * Moved wheel rebuilding script into a .py file. * Invoke wheel from command line instead of a py script. * travis cibuildwheel: install wheel Co-authored-by: Magnus Edenhill <magnus@edenhill.se>
1 parent 4824190 commit dc2033a

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ jobs:
4545
# Install cibuildwheel if this is a tagged PR
4646
before_install:
4747
- if [[ $TRAVIS_OS_NAME == "osx" ]]; then tools/prepare-osx.sh ${INTERPRETER_VERSION} /tmp/venv && source /tmp/venv/bin/activate; fi
48-
- if [[ -n $TRAVIS_TAG && -n $CIBW_BEFORE_BUILD ]]; then pip install cibuildwheel --force-reinstall; fi
48+
- if [[ -n $TRAVIS_TAG && -n $CIBW_BEFORE_BUILD ]]; then pip install -r tools/requirements-manylinux.txt --force-reinstall; fi
4949

5050
# Install interceptors
5151
# Install librdkafka if not CIBW_BEFORE_BUILD

tools/fixup-wheels.sh

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -117,9 +117,10 @@ fixup_wheel () {
117117
fixup_wheel_macosx
118118
fi
119119

120-
zip -r $fixed_whl .
121-
122120
popd # tmpdir
121+
122+
wheel pack $tmpdir -d $fixed_wheelhouse
123+
123124
rm -rf $tmpdir
124125

125126
echo "Fixed $fixed_whl"
@@ -165,6 +166,3 @@ fi
165166
for wheel in $wheelhouse/*${wheelmatch}*.whl ; do
166167
fixup_wheel "$wheel"
167168
done
168-
169-
170-

tools/requirements-manylinux.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
11
cibuildwheel
2+
wheel

0 commit comments

Comments
 (0)