Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add onetbb/2021.11.0 #20813

Closed
wants to merge 10 commits into from
Closed

Conversation

AndreyMlashkin
Copy link
Contributor

@AndreyMlashkin AndreyMlashkin commented Oct 28, 2023

Specify library name and version: onetbb/2021.11.0-rc1


@conan-center-bot

This comment has been minimized.

@@ -1,4 +1,7 @@
sources:
"2021.11.0-rc1":
url: "https://github.com/oneapi-src/oneTBB/archive/refs/tags/v2021.11.0-rc1.tar.gz"
sha256: "ff0fbbf6ffcb0e81beacfddf5ef5b1eab0bb16f4e4c4bae517ed1f4e3b269b47"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, fix this condition:

@property
def _tbbbind_supported(self):
return Version(self.version) >= "2021.1.1" and not self.settings.os == "Macos"

because tbbbind is available since 2021.11.0 (see oneapi-src/oneTBB#1132)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have Mac to verify that, so I will just apply it and lets see the CI output

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@AndreyMlashkin
Copy link
Contributor Author

@ilya-lavrenov @SSE4 @uilianries
please review

@ilya-lavrenov
Copy link
Contributor

@ilya-lavrenov @SSE4 @uilianries please review

why should we add RC to CCI?
I expect we need to wait for final release 2021.11.0, don't we?

@SSE4
Copy link
Contributor

SSE4 commented Nov 2, 2023

why should we add RC to CCI?

AFAIR it's not prohibited. sometimes it can takes literally months for software to stabilize from RC to release, and people cannot wait.

@uilianries
Copy link
Member

@AndreyMlashkin do you really need this RC version? We try to avoid alpha, beta and rc, because they will be "deprecated" as soon as we have the final release. The OneTBB is an active project, so it should not take so long.

@uilianries uilianries self-assigned this Nov 6, 2023
@AndreyMlashkin
Copy link
Contributor Author

@AndreyMlashkin do you really need this RC version? We try to avoid alpha, beta and rc, because they will be "deprecated" as soon as we have the final release. The OneTBB is an active project, so it should not take so long.

Okey, it's a valid point. I would leave this PR open till they have it released

@ilya-lavrenov
Copy link
Contributor

New release is available https://github.com/oneapi-src/oneTBB/releases/tag/v2021.11.0

@Nekto89
Copy link
Contributor

Nekto89 commented Nov 20, 2023

will this PR be updated for new release?

uilianries
uilianries previously approved these changes Nov 22, 2023
@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor

SpaceIm commented Nov 22, 2023

use release, not release candidate

Could you update PR title accordingly please?

@AndreyMlashkin AndreyMlashkin changed the title add onetbb/2021.11.0-rc1 add onetbb/2021.11.0 Nov 22, 2023
Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Failure in build 11 (4f2e659f9314680c0af24f79177947c05da0d805):

  • onetbb/2021.8.0:
    Didn't run or was cancelled before finishing

  • onetbb/2021.6.0:
    Didn't run or was cancelled before finishing

  • onetbb/2021.9.0:
    Didn't run or was cancelled before finishing

  • onetbb/2021.11.0:
    Error running command conan info onetbb/2021.11.0@#d3e307471b20b0a8239c71836edbfb24 --json {jsonName} -pr:h {profileHostName} -pr:b {profileBuildName}:

    [settings]
    arch=armv8
    build_type=Release
    compiler=apple-clang
    compiler.libcxx=libc++
    compiler.version=13.0
    os=Macos
    
    ...
    ERROR: hwloc/2.9.3: option 'shared' doesn't exist
    Possible options are ['with_libxml2']
    
  • onetbb/2021.7.0:
    Didn't run or was cancelled before finishing

  • onetbb/2021.3.0:
    Didn't run or was cancelled before finishing

  • onetbb/2021.10.0:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.


Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

See details:

Failure in build 11 (4f2e659f9314680c0af24f79177947c05da0d805):

  • onetbb/2021.10.0:
    Didn't run or was cancelled before finishing

  • onetbb/2021.11.0:
    Error running command conan graph info --requires onetbb/2021.11.0@#d3e307471b20b0a8239c71836edbfb24 -f json -pr:h /home/conan/w/prod-v2/bsr/46326/eabee/profile_osx_13_libcpp_17_apple-clang_release_armv8..txt -pr:b /home/conan/w/prod-v2/bsr/46326/eabee/profile_osx_13_libcpp_17_apple-clang_release_64..txt:

    ======== Computing dependency graph ========
    hwloc/2.9.3: Not found in local cache, looking in remotes...
    hwloc/2.9.3: Checking remote: conan-center
    hwloc/2.9.3: Downloaded recipe revision 526f2dfd53146a99475b1ee7cbe8cbfd
    Graph root
        cli
    Requirements
        hwloc/2.9.3#526f2dfd53146a99475b1ee7cbe8cbfd - Downloaded (conan-center)
        onetbb/2021.11.0#d3e307471b20b0a8239c71836edbfb24 - Cache
    
    ======== Computing necessary packages ========
    ERROR: onetbb/2021.11.0: Error in validate() method, line 98
    	if self._tbbbind_explicit_hwloc and not self.dependencies["hwloc"].options.shared:
    	ConanException: option 'shared' doesn't exist
    Possible options are ['with_libxml2']
    
  • onetbb/2021.8.0:
    Didn't run or was cancelled before finishing

  • onetbb/2021.7.0:
    Didn't run or was cancelled before finishing

  • onetbb/2021.9.0:
    Didn't run or was cancelled before finishing

  • onetbb/2021.6.0:
    Didn't run or was cancelled before finishing

  • onetbb/2021.3.0:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@Nekto89
Copy link
Contributor

Nekto89 commented Nov 24, 2023

Recipe needs to be updated because hwloc has been converted from "library" to "shared-library" 2 weeks ago

@ghost ghost mentioned this pull request Dec 14, 2023
3 tasks
@ghost ghost mentioned this pull request Jan 9, 2024
3 tasks
@ghost ghost mentioned this pull request Mar 27, 2024
This was referenced Apr 14, 2024
@uilianries
Copy link
Member

uilianries commented Jun 21, 2024

@AndreyMlashkin Thank you for your effort in this package update.

The PR #23651 merged the version 2021.12.0. I'm closing this PR because it contains conflicts and an older version.

$ conan search -r conancenter onetbb/2021.12.0
Found 1 pkg/version recipes matching onetbb/2021.12.0 in conancenter
conancenter
  onetbb
    onetbb/2021.12.0

Please, feel free to re-open in case you really this specific version.

@uilianries uilianries closed this Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants