onetbb: remove shared option + fix tbbmaloc & tbbproxy logic

[SpaceIm]

• regarding removal of shared option: see [question] Problem understanding a dependency in conancenter conan#15040 (comment)
• for tbbmaloc & tbbproxy, well current logic was super weird. It comes from onetbb: made tbbmalloc and tbbproxy enabled by default #17311, but it doesn't really make sense. These options didn't exist before 2021.5.0 or 2021.6.0, so they have to be removed in config_option, that's all.

---

• I've read the contributing guidelines.
• I've used a recent Conan client version close to the currently deployed.
• I've tried at least one configuration locally with the conan-center hook activated.

[ghost]

I detected other pull requests that are modifying onetbb/all recipe:

• [OneTBB] Deprecate support for shared option #20912
• add onetbb/2021.11.0 #20813
• Add onetbb/2021.5.0 needed by cctag/1.0.3 #18714

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

[valgur]

Thanks! I really hope this fixes the issue.

[SpaceIm]

Hum, another option I don't like in this recipe: interprocedural_optimization (added by #13386). It shouldn't be an option. There shouldn't be option doing babysitting of compiler/linker flags, there is tools.build.cflags/cxxflags/sharedlinkflags for this, with the benefit of ensuring consistent flags across all dependency graph. And anyway LTO shouldn't be enabled by default in this recipe (well in shared lib it's harmless but still).

[SpaceIm]

@danimtb @uilianries @RubenRBS I'm not even sure it will fix all issues related to missing onetbb packages in v2 pipeline. Since onetbb has dependencies, if I remove shared option of onetbb, it will build onetbb flavor with static dependencies only (I mean, does v2 pipeline still tries to build both -o *:shared=False AND -o *:shared=True even if root recipe doesn't have shared option?)?
So if a downstream recipe has a shared option, it will break with shared=True since conancenter won't have the flavor of onetbb with hwloc shared=True, correct?

[uilianries]

Removing the shared option sounds good to me.

I'll block to discuss first with Conan team, in case of side-effects.

We still could list all affected packages and run an internal CI build to regenerate after merging it, but still need to check what could happen with CI composition, like */*:shared=True/False and even mixed (Conan 1.x) for future PRs.

[uilianries]

After discussing with Conan team about this situation, indeed the hwloc will cause trouble due Conan 2.x CCI build configuration. So our better shot now is restricting hwloc to a shared library only.

I opened the PR #20976. That PR should be merged first, then we can update this one and merge it too.

Thank you @SpaceIm for not only opening the PR, but also sharing your investigation.

[fschoenm]

@uilianries Can this be merged now or is there something left to do?

[SpaceIm]

I've triggered a new build, now that #20976 has been merged.

[conan-center-bot]

Conan v1 pipeline ✔️

All green in build 3 (be9ffd2db81b086eec70eac0a5e5a00fdd564713):

• onetbb/2021.10.0:
  All packages built successfully! (All logs)

• onetbb/2021.9.0:
  All packages built successfully! (All logs)

• onetbb/2021.8.0:
  All packages built successfully! (All logs)

• onetbb/2021.7.0:
  All packages built successfully! (All logs)

• onetbb/2021.6.0:
  All packages built successfully! (All logs)

• onetbb/2021.3.0:
  All packages built successfully! (All logs)

---

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 3 (be9ffd2db81b086eec70eac0a5e5a00fdd564713):

• onetbb/2021.10.0:
  All packages built successfully! (All logs)

• onetbb/2021.9.0:
  All packages built successfully! (All logs)

• onetbb/2021.8.0:
  All packages built successfully! (All logs)

• onetbb/2021.7.0:
  All packages built successfully! (All logs)

• onetbb/2021.6.0:
  All packages built successfully! (All logs)

• onetbb/2021.3.0:
  All packages built successfully! (All logs)