Allow building and loading of TBBBind on macOS #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| DLD(__TBB_internal_allocate_binding_handler, allocate_binding_handler_ptr), | ||
| DLD(__TBB_internal_deallocate_binding_handler, deallocate_binding_handler_ptr), | ||
| DLD(__TBB_internal_apply_affinity, apply_affinity_ptr), | ||
| DLD(__TBB_internal_restore_affinity, restore_affinity_ptr), | ||
| #endif |
There was a problem hiding this comment.
can it be dynamically understood that tbbbind does not have all symbols and "bind"-related symbols are just not set upon loading of tbbbind?
There was a problem hiding this comment.
dynamic_link functionality guarantees that either all of requested symbols are loaded, or none of them, if something is missing. Thus, we shouldn't expect hwloc's cpubind related symbols here in the first place.
Signed-off-by: Isaev, Ilya <ilya.isaev@intel.com>
Signed-off-by: Isaev, Ilya <ilya.isaev@intel.com>
isaevil
force-pushed
the
dev/isaevil/tbbbind-macos
branch
from
01ec0f8
to
6d3c952
Compare
pavelkumbrasev
approved these changes
Aug 1, 2023
3 tasks
AndreyMlashkin
pushed a commit
to AndreyMlashkin/conan-center-index
that referenced
this pull request
Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current build infrastructure and code base don't allow to build and use TBBBind on macOS, while HWLOC is able to recognize hybrid cores on macOS M1/M2. With this patch user may build TBBBind on macOS and be able to use
tbb::infonamespace to obtain high-level information about the system and limit task_arena accordingly (without actual CPU binding since such functionality is not supported on macOS via HWLOC).Fixes # - issue number(s) if exists
Type of change
Choose one or multiple, leave empty if none of the other choices apply
Add a respective label(s) to PR if you have permissions
Tests
Documentation
Breaks backward compatibility
Notify the following users
List users with
@to send notificationsOther information