Add LookupConstructors and fix logic in IsConstructor for templates
#535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
lib/Interpreter/CppInterOp.cpp
Outdated
| if (R.empty()) | ||
| return; | ||
| Sema::NotForRedeclaration); | ||
| auto DC = clang::Decl::castToDeclContext(D); |
Contributor
There was a problem hiding this comment.
warning: 'auto DC' can be declared as 'auto *DC' [llvm-qualified-auto]
Suggested change
| auto DC = clang::Decl::castToDeclContext(D); | |
| auto *DC = clang::Decl::castToDeclContext(D); |
aaronj0
force-pushed
the
constructor-lookups
branch
from
71c60ae to
349ff71
Compare
vgvassilev
reviewed
Mar 21, 2025
aaronj0
force-pushed
the
constructor-lookups
branch
2 times, most recently
from
783838a to
222fd9c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #535 +/- ##
==========================================
+ Coverage 75.46% 75.94% +0.47%
==========================================
Files 9 9
Lines 3628 3646 +18
==========================================
+ Hits 2738 2769 +31
+ Misses 890 877 -13
🚀 New features to boost your workflow:
|
aaronj0
force-pushed
the
constructor-lookups
branch
from
222fd9c to
a816f36
Compare
Collaborator
Author
|
The added tests here depend on #536 to obtain the function signatures correctly for |
vgvassilev
force-pushed
the
constructor-lookups
branch
from
f3a3b65 to
68b883c
Compare
aaronj0
force-pushed
the
constructor-lookups
branch
from
68b883c to
0c0872d
Compare
vgvassilev
reviewed
Mar 31, 2025
aaronj0
force-pushed
the
constructor-lookups
branch
3 times, most recently
from
7dc0ddf to
dda332e
Compare
vgvassilev
reviewed
Mar 31, 2025
aaronj0
force-pushed
the
constructor-lookups
branch
2 times, most recently
from
0bf59e5 to
247a4f1
Compare
Also splits IsTemplatedFunction into `IsTemplatedFunction` for FunctionTemplateDecl, and `IsTemplateInstantiationOrSpecialization` when we have an instantiation or a specialization. Accumulate constructors with the new lookup in `GetClassTemplatedMethods` enabling 8 tests.
aaronj0
force-pushed
the
constructor-lookups
branch
from
247a4f1 to
4159d1b
Compare
aaronj0
force-pushed
the
constructor-lookups
branch
from
cfebdcc to
abfe633
Compare
aaronj0
force-pushed
the
constructor-lookups
branch
from
abfe633 to
6e57f12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
LookupConstructorsand fixes logic inIsConstructorfor templates. Accumulate constructors with this new lookup inGetClassTemplatedMethodsenabling 8 tests. Also splits IsTemplatedFunction intoIsTemplatedFunctionfor FunctionTemplateDecl, andIsTemplateInstantiationOrSpecializationwhen we have an instantiation or a specialization.