Improve GetMethodTemplate and implement Cppyy::ResolveName
#135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than try Instantiate if the set is single, we use BestOverloadMatch by default
vgvassilev
reviewed
Mar 31, 2025
aaronj0
force-pushed
the
template-methods
branch
from
bdf3077 to
9550606
Compare
aaronj0
force-pushed
the
template-methods
branch
from
9550606 to
b422a61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve handling of GetMethodTemplate to fall back on Instantiate (required along with compiler-research/CppInterOp#535)
Implement
Cppyy::ResolveNameDrop dead code of helpers for
GetMethodTemplatethat are no longer required