Revert build changes #4087
Merged
Revert build changes #4087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-app#4083)" This reverts commit c198580.
This reverts commit 356aa87.
|
Thanks for diagnosing the problem, @domdomegg . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Ah I was so hopeful for #4076 and #4083, however unfortunately they are failing the build.
This is because to support the Android Gradle build tools 4.1 we need the triplet play plugin version 3 (see Triple-T/gradle-play-publisher#790). This requires migrating to JSON service account credentials from GCP (should be just a matter of finding the service account and generating JSON credentials, then encrypting it as we did before for the .p12 key).
This undoes the changes temporarily until we can migrate to using JSON service account credentials.