Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support auto resolution strategy in AGP 4.1 #790

Closed
SUPERCILEX opened this issue Mar 16, 2020 · 3 comments
Closed

Support auto resolution strategy in AGP 4.1 #790

SUPERCILEX opened this issue Mar 16, 2020 · 3 comments
Labels
bug Indicates an unexpected problem or unintended behavior feature:apk Involves APKs feature:bundle Involves app bundles
Milestone

Comments

@SUPERCILEX
Copy link
Collaborator

Modifying properties after evaluation isn't supported anymore, so we'll have to use the new variant API: https://github.com/ducrohet/versionCode-4.0-sample/blob/22ade6bb5bbe697e022d325ece78232b8af0e32a/buildSrc/src/main/java/com/example/build/CustomPlugin.kt#L34.

@SUPERCILEX SUPERCILEX added bug Indicates an unexpected problem or unintended behavior feature:bundle Involves app bundles feature:apk Involves APKs labels Mar 16, 2020
@SUPERCILEX SUPERCILEX added this to the Backlog milestone Mar 16, 2020
@smworks
Copy link

smworks commented May 7, 2020

Is this related to the fact, that versionCode is not updated using auto resolutionStrategy?
The issue is that if I keep deploying using this plugin, app still reports versionCode that was last manually set in build.gradle, even though market shows updated versionCode. Should I expect this issue to be addressed?

@SUPERCILEX
Copy link
Collaborator Author

Yup, that's the issue. Once AGP 4.0 goes stable, I should be able to release a version of GPP that uses those new APIs to get auto resolution working again.

@SUPERCILEX
Copy link
Collaborator Author

Fixed in 4d52010, 354812b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior feature:apk Involves APKs feature:bundle Involves app bundles
Projects
None yet
Development

No branches or pull requests

2 participants