Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ABT and Gradle versions #4076

Merged
merged 1 commit into from
Dec 7, 2020

Conversation

domdomegg
Copy link
Member

Description (required)

#171

Bumps Android Build Tools Gralde plugin and Gradle versions to eliminate many build warnings and to get performance improvements. This should also make running tests in CI easier (I'd like to get UI tests working in either Travis or GitHub Actions at some point).

Tests performed (required)

Tested BetaDebug on Oneplus 6T with API level 29.

@codecov-io
Copy link

Codecov Report

Merging #4076 (755dbd0) into master (b24ed1c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4076   +/-   ##
=========================================
  Coverage     10.60%   10.60%           
  Complexity      476      476           
=========================================
  Files           343      343           
  Lines         12875    12875           
  Branches        997      997           
=========================================
  Hits           1366     1366           
  Misses        11441    11441           
  Partials         68       68           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b24ed1c...755dbd0. Read the comment docs.

@domdomegg domdomegg marked this pull request as ready for review December 6, 2020 20:12
@misaochan
Copy link
Member

Thanks @domdomegg ! Glad to see you back, too. :)

@misaochan misaochan merged commit 356aa87 into commons-app:master Dec 7, 2020
@domdomegg domdomegg deleted the 171-abt-4.1.1-gradle-6.7 branch December 7, 2020 17:40
domdomegg added a commit to domdomegg/apps-android-commons that referenced this pull request Dec 8, 2020
misaochan pushed a commit that referenced this pull request Dec 9, 2020
* Revert "#171: Bump Triple-T gradle-play-publisher (#4083)"

This reverts commit c198580.

* Revert "Bump ABT and Gradle versions (#4076)"

This reverts commit 356aa87.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants