Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI with GitHub Actions #4078

Merged
merged 3 commits into from
Dec 21, 2020

Conversation

domdomegg
Copy link
Member

@domdomegg domdomegg commented Dec 6, 2020

Description (required)

Depends on #4076

Adds CI with GitHub actions. It runs much faster (7 minutes vs. 19 minutes when you include time to boot the agent) and integrates with GitHub more closely. Also makes it easier for people to run CI on forks.

This check has passed here: https://github.com/domdomegg/apps-android-commons/actions/runs/404423357

NB: this only does the CI part, not the CD part that Travis also does for us at the moment.

@maskaravivek
Copy link
Member

maskaravivek commented Dec 6, 2020

We will also need to include a script for automatic alpha releases. As of now, it's integrated into our Travis flow. Ref: #1056

Edit: We currently do it using ./gradlew publishProdReleaseApk. We will just have to make sure that a bunch of encrypted environment variables, Keystore etc is available when this command is run.

@codecov-io
Copy link

Codecov Report

Merging #4078 (d02c368) into master (b24ed1c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4078   +/-   ##
=========================================
  Coverage     10.60%   10.60%           
  Complexity      476      476           
=========================================
  Files           343      343           
  Lines         12875    12875           
  Branches        997      997           
=========================================
  Hits           1366     1366           
  Misses        11441    11441           
  Partials         68       68           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b24ed1c...d02c368. Read the comment docs.

@domdomegg domdomegg marked this pull request as ready for review December 13, 2020 12:47
@domdomegg domdomegg marked this pull request as draft December 13, 2020 12:48
@domdomegg domdomegg marked this pull request as ready for review December 19, 2020 01:03
@domdomegg domdomegg mentioned this pull request Dec 19, 2020
@misaochan misaochan merged commit 52ab160 into commons-app:master Dec 21, 2020
@misaochan
Copy link
Member

Thanks a lot @domdomegg .

@domdomegg
Copy link
Member Author

Ah my bad, I think this still depends on updating Gradle which requires moving to JSON service credentials unfortunately. :(

Probably need to revert until that's sorted :(

domdomegg pushed a commit that referenced this pull request Dec 21, 2020
misaochan pushed a commit that referenced this pull request Dec 22, 2020
* Revert "Add CI with GitHub Actions (#4078)"

This reverts commit 52ab160.

* Downgrade ubuntu version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants