Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to AndroidX #2593

Closed
maskaravivek opened this issue Mar 14, 2019 · 2 comments
Closed

Migrate to AndroidX #2593

maskaravivek opened this issue Mar 14, 2019 · 2 comments

Comments

@maskaravivek
Copy link
Member

maskaravivek commented Mar 14, 2019

Summary:

While working on #2591 I thought it would be nice to migrate to AndroidX as well.

Recently we ran into issues while adding new libraries or while updating to latest versions of existing libraries(which used AndroidX). Eg. #1192

https://developer.android.com/jetpack/androidx/migrate

@dbrant
Copy link
Collaborator

dbrant commented Mar 14, 2019

Whoops, you'll notice that I've already got a PR (#2595) that updates to API 28 (as well as library versions), and also fixes and updates CI to match these updates, along with a few other related issues in the code.

Perhaps the PR to migrate to AndroidX can be a separate one?

@maskaravivek
Copy link
Member Author

Perhaps the PR to migrate to AndroidX can be a separate one?

Yes, makes sense. I will rebase my PR(#2594) once #2595 gets merged.

domdomegg pushed a commit that referenced this issue Mar 16, 2019
* Update dependencies and migrate to androidX
* Make gradle properties tidy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants