Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to androidX #2594

Merged
merged 5 commits into from
Mar 16, 2019
Merged

Conversation

maskaravivek
Copy link
Member

@maskaravivek maskaravivek commented Mar 14, 2019

Description (required)

Fixes #2593

What changes did you make and why?

  • migrate to android X

Tests performed (required)

:app:build

Copy link
Member

@domdomegg domdomegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested 2.10.1-debug-androidXMigration~cbd344d99. All seems to work.

Beta Commons upload.

Can you make the changes requested to keep gradle.properties tidy, then happy to merge.

gradle.properties Show resolved Hide resolved
gradle.properties Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Mar 16, 2019

Codecov Report

Merging #2594 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2594      +/-   ##
=========================================
+ Coverage    2.69%   2.69%   +<.01%     
=========================================
  Files         258     258              
  Lines       12319   12318       -1     
  Branches     1117    1117              
=========================================
  Hits          332     332              
+ Misses      11961   11960       -1     
  Partials       26      26
Impacted Files Coverage Δ
...fr/free/nrw/commons/mwapi/model/MwQueryResult.java 0% <ø> (ø) ⬆️
...n/java/fr/free/nrw/commons/CommonsApplication.java 0% <ø> (ø) ⬆️
...ons/explore/categories/SearchCategoryFragment.java 0% <ø> (ø) ⬆️
...va/fr/free/nrw/commons/campaigns/CampaignView.java 0% <ø> (ø) ⬆️
...ks/locations/BookmarkLocationsContentProvider.java 0% <ø> (ø) ⬆️
.../java/fr/free/nrw/commons/di/NetworkingModule.java 0% <ø> (ø) ⬆️
...c/main/java/fr/free/nrw/commons/utils/UiUtils.java 0% <ø> (ø) ⬆️
...n/java/fr/free/nrw/commons/MediaDataExtractor.java 0% <ø> (ø) ⬆️
...free/nrw/commons/theme/NavigationBaseActivity.java 0% <ø> (ø) ⬆️
...fr/free/nrw/commons/settings/SettingsActivity.java 0% <ø> (ø) ⬆️
... and 114 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb40c24...6467db5. Read the comment docs.

@maskaravivek
Copy link
Member Author

@domdomegg Thanks for reviewing and testing this PR. I made the requested changes :)

@maskaravivek maskaravivek changed the title Update dependencies and migrate to androidX Migrate to androidX Mar 16, 2019
Copy link
Member

@domdomegg domdomegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested 2.10.1-debug-androidXMigration~6467db5ef on API level 28, 25, 19.

Tested 2.10.1-debug-androidXMigration~6467db5ef on API level 28

Beta Commons 28
Beta Commons 25
Beta Commons 19

@maskaravivek
Copy link
Member Author

@domdomegg Can the PR be merged? I have other changes that I would like to do once this is merged to master. :)

@domdomegg domdomegg merged commit 57e685c into commons-app:master Mar 16, 2019
@whym whym mentioned this pull request Mar 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants