Update to API 28, and fix CI issues. #2595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update jacoco plugin to work with latest gradle.
The functions it provides are no longer necessary. This also removes a homemade "evaluate" function, which is readily available in the Support library.
This library has not been updated in two years (may no longer be maintained?), and no longer works with the latest RxJava.
Running test coverage on every single build while developing in the IDE is quite a waste of time.
The build output was getting extremely long, and was actually causing the build to fail because of the sheer size of the log.
Stop CI messages from exploding to 10k+ lines.
The project's instrumented tests consist of a single test which sets a SharedPreference, then verified that the SharedPreference was set. I humbly submit that this is not worth the trouble of having the CI server download the system image, spin up an emulator, load the APK, and run it just for this purpose. Once the instrumented tests are ready for prime time, we can reinstate instrumented tests in CI.
Closed
Codecov Report
@@ Coverage Diff @@
## master #2595 +/- ##
=========================================
- Coverage 5.91% 5.89% -0.02%
=========================================
Files 258 258
Lines 12324 12311 -13
Branches 1114 1113 -1
=========================================
- Hits 729 726 -3
+ Misses 11536 11527 -9
+ Partials 59 58 -1
Continue to review full report at Codecov.
|
maskaravivek
approved these changes
Mar 15, 2019
This was referenced Mar 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.