Hyundai CAN-FD: Move CRC compute function to common Hyundai safety #1634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunnyhaibin
changed the title
This was referenced Sep 5, 2023
sunnyhaibin
force-pushed
the
hkg-canfd-compute-chksum-common
branch
from
248cd90 to
09ba2d9
Compare
…mpute-chksum-common # Conflicts: # board/safety/safety_subaru.h
board/safety/safety_subaru.h
Outdated
| @@ -232,7 +232,7 @@ static int subaru_tx_hook(CANPacket_t *to_send) { | |||
| if (addr == MSG_SUBARU_ES_Distance) { | |||
| int cruise_throttle = (GET_BYTES(to_send, 2, 2) & 0xFFFU); | |||
| bool cruise_cancel = GET_BIT(to_send, 56U) != 0U; | |||
|
|
|||
There was a problem hiding this comment.
revert this change to the subaru safety
board/safety/safety_hyundai_canfd.h
Outdated
| } | ||
|
|
||
| return crc; | ||
| return hyundai_common_canfd_compute_checksum(to_push); |
There was a problem hiding this comment.
no need to wrap this in the CAN FD safety
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move CAN-FD CRC compute function to shared Hyundai safety. The 2023 Palisade/Telluride ports compute checksum for
SCC12 | 0x421in Hyundai CAN safety.Prerequisite of