Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

safety: common gas/brake tests #1416

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

safety: common gas/brake tests #1416

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ad3ab19
better name
sshane May 17, 2023
f8b9660
copilot wants to give it a go lol
sshane May 17, 2023
b425893
fixes
sshane May 17, 2023
12511d2
not sure what that is
sshane May 17, 2023
051bdee
copilot's kinda cool!
sshane May 17, 2023
043e044
working
sshane May 17, 2023
688ed42
fixes
sshane May 17, 2023
c4bb6a5
remove gm gas test
sshane May 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
not sure what that is
  • Loading branch information
@sshane
sshane committed May 17, 2023
commit 12511d29d85a1f49ef3db346d48727558064a621
4 changes: 1 addition & 3 deletions tests/safety/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,9 +204,7 @@ def test_gas_brake_limits_correct(self):
def test_gas_brake_actuation_limits(self, stock_longitudinal=False):
# Test that gas and brake are limited to their respective bounds
limits = ((self.MIN_GAS, self.MAX_GAS, ALTERNATIVE_EXPERIENCE.DEFAULT),
(self.MIN_GAS, self.MAX_GAS, ALTERNATIVE_EXPERIENCE.RAISE_LONGITUDINAL_LIMITS_TO_ISO_MAX),
(self.MIN_GAS, self.MAX_GAS, ALTERNATIVE_EXPERIENCE.RAISE_LONGITUDINAL_LIMITS_TO_ISO_MAX_WITHOUT_GAS),
(self.MIN_GAS, self.MAX_GAS, ALTERNATIVE_EXPERIENCE.RAISE_LONGITUDINAL_LIMITS_TO_ISO_MAX_WITHOUT_BRAKE))
(self.MIN_GAS, self.MAX_GAS, ALTERNATIVE_EXPERIENCE.RAISE_LONGITUDINAL_LIMITS_TO_ISO_MAX))

for min_gas, max_gas, alternative_experience in limits:
# enforce we don't skip over 0 or inactive gas
Expand Down