Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

safety: common gas/brake tests #1416

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

safety: common gas/brake tests #1416

wants to merge 8 commits into from

Conversation

sshane
Copy link
Contributor

@sshane sshane commented May 17, 2023 •
edited
Loading

  • remove GM's existing tests and combine
  • handle honda

@sshane sshane changed the title tests: common gas/brake tests safety: common gas/brake tests May 17, 2023
@sshane sshane added car safety vehicle-specific safety code tests cleanup labels May 17, 2023
@sshane
Copy link
Contributor Author

sshane commented May 17, 2023 •
edited
Loading

going to want on this until Ford is in with its own tests, since there are multiple different ways to write this, and having ford, gm, and honda all together will help me see how we can do that (for ex. honda tests gas and accel in one message, gm tests gas and brake as separate messages)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
car safety vehicle-specific safety code cleanup tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sshane