Add Genesis G80 to special panda safety mode #2602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you provide a route from this branch that we can use for our tests? Currently, there is no test route for the Genesis G80. |
|
Sure -- is there a way to get the route directly from the device without using https://my.comma.ai? |
|
No, the route will need to be fully uploaded. You can check the upload status in your my.comma.ai/useradmin page. |
|
Yeah so I wasn't able to connect my device to my account (scanning the QR code in the app doesn't do anything) so my useradmin page doesn't have any devices, not sure if there's another way to connect them? Might be related issue on the Comma connect side commaai/connect#2 |
|
Was able to get account linked. Here's the route ID 6b301bf83f10aa90|2020-11-22--16-45-07 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Upon activating OP in 2018 Genesis G80, screen immediately shows "Take Control Immediately, Controls Mismatch" and disengages. This PR is to add the G80 to special panda safety mode to resolve this issue.
Verification I was able to verify by driving my G80 on my fork and engage OP without encountering the Controls Mismatch screen. I am unable to provide the exact route because I am unable to connect my device with Comma Connect (scanning QR code doesn't do anything), so I don't have access to useradmin.
Route
Route: 6b301bf83f10aa90|2020-11-22--16-45-07