Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RPM signal #216

Merged
merged 2 commits into from
Apr 2, 2020
Merged

Add RPM signal #216

merged 2 commits into from
Apr 2, 2020

Conversation

arne182
Copy link
Contributor

@arne182 arne182 commented Feb 6, 2020

Thanks @Hubblesphere

@nelsonjchen
Copy link
Contributor

I'm trying to diagnose why the engine braking isn't working with the ACC_CONTROL command and having this signal in the DBCs would be very helpful.

@pd0wm
Copy link
Contributor

pd0wm commented Mar 19, 2020

Where is the 0.78125 coming from?

@arne182
Copy link
Contributor Author

arne182 commented Mar 19, 2020

https://github.com/Glidepathuav/opendbc/blob/master/2017_toyota_master.dbc
The leaked Toyota opendbc

@pd0wm pd0wm merged commit cc09af7 into commaai:master Apr 2, 2020
nelsonjchen pushed a commit to nelsonjchen/opendbc that referenced this pull request May 4, 2020
@arne182 @nelsonjchen
Add RPM signal (commaai#216)
956bc03 
* Add RPM signal

Thanks @Hubblesphere

* run generator for engine rpm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arne182 @nelsonjchen @pd0wm