chore: remove smart wallet check from cli prompt #2287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alessey
reviewed
Apr 16, 2025
| `NEXT_PUBLIC_ONCHAINKIT_PROJECT_NAME=${projectName}\nNEXT_PUBLIC_ONCHAINKIT_API_KEY=${clientKey}\nNEXT_PUBLIC_ONCHAINKIT_WALLET_CONFIG=${ | ||
| smartWallet ? 'smartWalletOnly' : 'all' | ||
| }`, | ||
| `NEXT_PUBLIC_ONCHAINKIT_PROJECT_NAME=${projectName}\nNEXT_PUBLIC_ONCHAINKIT_API_KEY=${clientKey}\nNEXT_PUBLIC_ONCHAINKIT_WALLET_CONFIG=all`, |
Contributor
There was a problem hiding this comment.
NEXT_PUBLIC_ONCHAINKIT_WALLET_CONFIG isn't necessary, this already uses the default <OnchainKitProvider/> which adds wagmi with smart wallet 'all'
dschlabach
approved these changes
Apr 17, 2025
dgca
approved these changes
Apr 17, 2025
Dargon789
pushed a commit
to Dargon789/onchainkit
that referenced
this pull request
May 26, 2025
Dargon789
added a commit
to Dargon789/onchainkit
that referenced
this pull request
Dec 15, 2025
* Add .circleci/config.yml * chore: add context exports (coinbase#2261) * feat: Add batch ENS / Basename resolution with useAddresses hook and getAddresses utility (coinbase#2277) * chore: add provider exports back (coinbase#2278) * refactor: Replace Packemon with Vite (coinbase#2227) * fix: Don't clean out out dir when building in dev mode (coinbase#2279) * fix wallet modal (coinbase#2282) * fix: Separate deafult Wagmi and Query providers (coinbase#2280) * chore: show connect button when disconnected in Identity demo (coinbase#2285) * Fix: Flaky AppchainBridgeProvider network toggle test (coinbase#2288) * refactor: send display name (coinbase#2283) * chore: Refactor getNames utility to leverage batch processing with getAddresses (coinbase#2281) * chore: fix typos in documentation (coinbase#2286) * chore: Dynamically set version in version.ts (coinbase#2290) * fix: viem version (coinbase#2291) * fix: viem (coinbase#2293) * fix: viem (coinbase#2295) * chore: Add @farcaster/frame-sdk dependency to minikit templates (coinbase#2297) * chore: bump cli templates deps (coinbase#2296) * chore: remove smart wallet check from cli prompt (coinbase#2287) * fix: ready options (coinbase#2300) * fix: authenticate against user fid (coinbase#2299) * chore: version packages v 0.38.8 🌊 (coinbase#2276) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Dan Cortes <3639170+dgca@users.noreply.github.com> * fix: OnchainKit package.json publishConfig.access = public (coinbase#2306) * chore: add redirect for `getOnrampBuyUrl` (coinbase#2104) * fix: signature provider unmount reset (coinbase#2172) * fix: Updates playground to remove outdated imports (coinbase#2294) * chore(deps): bump next from 14.2.25 to 14.2.26 (coinbase#2215) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: update `create-onchain` version (coinbase#2315) * fix: rpcUrl (coinbase#2319) * chore: update release workflows (coinbase#2314) * fix: fix root build command (coinbase#2320) * fix: fix build command in workflow (coinbase#2321) * fix: narrow filtering for release workflow (coinbase#2322) * chore: version packages v0.38.9 🌊 (coinbase#2323) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Alissa Crane <alissacranespam@gmail.com> * fix: support an insecure fallback for session id to allow for testing on http contexts (coinbase#2318) Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * chore: Make create-onchain library public (coinbase#2324) * chore: Don't ask to generate manifest during app creation in create-onchain (coinbase#2326) * fix: Basenames bidirectional validation (coinbase#2329) * chore: version packages v0.38.10 🌊 (coinbase#2330) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Alissa Crane <alissacranespam@gmail.com> * fix: getSocials (coinbase#2333) * docs: fix broken link (coinbase#2331) * feat: Make sign up button optional (coinbase#2332) * chore: Release changesets (coinbase#2342) * Chore: workflow improvement for vscode/cursor users (coinbase#2334) * chore: version packages 🚀 (coinbase#2343) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Dan Cortes <3639170+dgca@users.noreply.github.com> * chore: enable paymaster for wallet advanced Send (coinbase#2335) * fix: MiniKit frames connector (coinbase#2347) * chore: version packages 🚀 (coinbase#2348) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Dan Cortes <3639170+dgca@users.noreply.github.com> * fix: Update wagmi config if connectors change (coinbase#2350) * chore: version packages 🚀 (coinbase#2352) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Dan Cortes <3639170+dgca@users.noreply.github.com> * chore(deps-dev): bump vite from 6.2.3 to 6.2.7 (coinbase#2327) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: Use signed commits for Changesets action (coinbase#2351) * chore: Update MiniKit mini app manifest (coinbase#2355) * chore: version packages 🚀 (coinbase#2362) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Dan Cortes <3639170+dgca@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Alissa Crane <alissacranespam@gmail.com> Co-authored-by: Paul Cramer <paulccramer@gmail.com> Co-authored-by: Dan Cortes <3639170+dgca@users.noreply.github.com> Co-authored-by: Brendan from DeFi <brendan.forster@coinbase.com> Co-authored-by: leopardracer <136604165+leopardracer@users.noreply.github.com> Co-authored-by: Adam <alessey@gmail.com> Co-authored-by: Zach Blake <ztb@pm.me> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Daniel Schlabach <31226559+dschlabach@users.noreply.github.com> Co-authored-by: Teimur Gasanov <teymurgg321@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: xtbase <teaonbase@gmail.com> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Co-authored-by: GarmashAlex <garmasholeksii@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
default to create-onchain wallet config to
alland remove cli promptNotes to reviewers
How has it been tested?