refactor: Replace Packemon with Vite #2227

dgca · 2025-04-04T17:26:34Z

What changed? Why?

Removes Packemon and tsup in favor of Vite.

Why?

Currently, we use Packemon for building the production build, and tsup for building the development build.

Packemon uses Rollup under the hood for bundling, while tsup uses ESBuild. This was making it really hard to do things like adding a babel plugin since ESBuild doesn't support that out of the box.

Vite uses Rollup for bundling, and though ESBuild is faster than Rollup, I'm seeing that the build is actually faster due to the type generation step. Not by much, only a second or two.

I also did the following:

Removed storybook
- IMO, we should consider using Storybook, but with only a handful of stories and ongoing discussions about what docs and the V1 component API looks like, I figured it was a good time to cut it. We can bring it back in very easily if we want to adopt it more fully
- Cleaned up some scripts. There were scripts that were doing the same thing, and some that weren't used.
Renamed the earn/mocks/index.ts file to mocks.test.ts. Otherwise, it would get picked up by the build script.

Notes to reviewers

How has it been tested?

Tests are passing
Verified file generation manually

vercel · 2025-04-04T17:26:38Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
onchainkit-coverage	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 11, 2025 10:28pm
onchainkit-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 11, 2025 10:28pm
onchainkit-routes	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 11, 2025 10:28pm

Copilot

Copilot reviewed 30 out of 32 changed files in this pull request and generated no comments.

Files not reviewed (2)

.github/workflows/check.yml: Language not supported
packages/onchainkit/package.json: Language not supported

Comments suppressed due to low confidence (1)

.github/workflows/lint.yml:24

Verify that the change from 'pnpm f:ock ci:lint' to 'pnpm f:ock lint' is intentional and that it aligns with your CI linting requirements.

run: pnpm f:ock lint

cpcramer · 2025-04-07T17:01:31Z

Builds as expected on my end but will wait for more reviews / discussions before stamping. In general i'm in favor of moving away from Packemon to a more popular bundler

…ncluded in build

alessey

LGTM

* Add .circleci/config.yml * chore: add context exports (coinbase#2261) * feat: Add batch ENS / Basename resolution with useAddresses hook and getAddresses utility (coinbase#2277) * chore: add provider exports back (coinbase#2278) * refactor: Replace Packemon with Vite (coinbase#2227) * fix: Don't clean out out dir when building in dev mode (coinbase#2279) * fix wallet modal (coinbase#2282) * fix: Separate deafult Wagmi and Query providers (coinbase#2280) * chore: show connect button when disconnected in Identity demo (coinbase#2285) * Fix: Flaky AppchainBridgeProvider network toggle test (coinbase#2288) * refactor: send display name (coinbase#2283) * chore: Refactor getNames utility to leverage batch processing with getAddresses (coinbase#2281) * chore: fix typos in documentation (coinbase#2286) * chore: Dynamically set version in version.ts (coinbase#2290) * fix: viem version (coinbase#2291) * fix: viem (coinbase#2293) * fix: viem (coinbase#2295) * chore: Add @farcaster/frame-sdk dependency to minikit templates (coinbase#2297) * chore: bump cli templates deps (coinbase#2296) * chore: remove smart wallet check from cli prompt (coinbase#2287) * fix: ready options (coinbase#2300) * fix: authenticate against user fid (coinbase#2299) * chore: version packages v 0.38.8 🌊 (coinbase#2276) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Dan Cortes <3639170+dgca@users.noreply.github.com> * fix: OnchainKit package.json publishConfig.access = public (coinbase#2306) * chore: add redirect for `getOnrampBuyUrl` (coinbase#2104) * fix: signature provider unmount reset (coinbase#2172) * fix: Updates playground to remove outdated imports (coinbase#2294) * chore(deps): bump next from 14.2.25 to 14.2.26 (coinbase#2215) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: update `create-onchain` version (coinbase#2315) * fix: rpcUrl (coinbase#2319) * chore: update release workflows (coinbase#2314) * fix: fix root build command (coinbase#2320) * fix: fix build command in workflow (coinbase#2321) * fix: narrow filtering for release workflow (coinbase#2322) * chore: version packages v0.38.9 🌊 (coinbase#2323) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Alissa Crane <alissacranespam@gmail.com> * fix: support an insecure fallback for session id to allow for testing on http contexts (coinbase#2318) Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * chore: Make create-onchain library public (coinbase#2324) * chore: Don't ask to generate manifest during app creation in create-onchain (coinbase#2326) * fix: Basenames bidirectional validation (coinbase#2329) * chore: version packages v0.38.10 🌊 (coinbase#2330) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Alissa Crane <alissacranespam@gmail.com> * fix: getSocials (coinbase#2333) * docs: fix broken link (coinbase#2331) * feat: Make sign up button optional (coinbase#2332) * chore: Release changesets (coinbase#2342) * Chore: workflow improvement for vscode/cursor users (coinbase#2334) * chore: version packages 🚀 (coinbase#2343) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Dan Cortes <3639170+dgca@users.noreply.github.com> * chore: enable paymaster for wallet advanced Send (coinbase#2335) * fix: MiniKit frames connector (coinbase#2347) * chore: version packages 🚀 (coinbase#2348) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Dan Cortes <3639170+dgca@users.noreply.github.com> * fix: Update wagmi config if connectors change (coinbase#2350) * chore: version packages 🚀 (coinbase#2352) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Dan Cortes <3639170+dgca@users.noreply.github.com> * chore(deps-dev): bump vite from 6.2.3 to 6.2.7 (coinbase#2327) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: Use signed commits for Changesets action (coinbase#2351) * chore: Update MiniKit mini app manifest (coinbase#2355) * chore: version packages 🚀 (coinbase#2362) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Dan Cortes <3639170+dgca@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Alissa Crane <alissacranespam@gmail.com> Co-authored-by: Paul Cramer <paulccramer@gmail.com> Co-authored-by: Dan Cortes <3639170+dgca@users.noreply.github.com> Co-authored-by: Brendan from DeFi <brendan.forster@coinbase.com> Co-authored-by: leopardracer <136604165+leopardracer@users.noreply.github.com> Co-authored-by: Adam <alessey@gmail.com> Co-authored-by: Zach Blake <ztb@pm.me> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Daniel Schlabach <31226559+dschlabach@users.noreply.github.com> Co-authored-by: Teimur Gasanov <teymurgg321@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: xtbase <teaonbase@gmail.com> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Co-authored-by: GarmashAlex <garmasholeksii@gmail.com>

dgca added 4 commits April 3, 2025 18:23

Testing out vite for bundling

99e0290

Put source files in /src

360fc95

Save

b4ff9e0

Get latest version of /src

a7af687

Merge tsconfig

6c70bb6

vercel bot deployed to Preview – onchainkit-routes April 4, 2025 17:31 View deployment

vercel bot had a problem deploying to Preview – onchainkit-coverage April 4, 2025 17:32 Failure

vercel bot had a problem deploying to Preview – onchainkit-playground April 4, 2025 17:32 Failure

Update lockfile

aefd19f

vercel bot deployed to Preview – onchainkit-routes April 4, 2025 17:33 View deployment

vercel bot deployed to Preview – onchainkit-playground April 4, 2025 17:35 View deployment

vercel bot deployed to Preview – onchainkit-coverage April 4, 2025 17:37 View deployment

Fix lockfile conflict

ecf9eaa

vercel bot deployed to Preview – onchainkit-routes April 4, 2025 17:37 View deployment

github-actions bot added pkg: swap labels Apr 4, 2025

vercel bot deployed to Preview – onchainkit-playground April 4, 2025 17:38 View deployment

vercel bot deployed to Preview – onchainkit-coverage April 4, 2025 17:41 View deployment

Don't run prettier as part of lint

c9b2505

vercel bot deployed to Preview – onchainkit-routes April 4, 2025 17:51 View deployment

vercel bot deployed to Preview – onchainkit-playground April 4, 2025 17:52 View deployment

vercel bot deployed to Preview – onchainkit-coverage April 4, 2025 17:55 View deployment

dgca marked this pull request as ready for review April 4, 2025 20:29

dgca requested a review from Copilot April 5, 2025 00:08

Copilot AI reviewed Apr 5, 2025

View reviewed changes

Merge dev, fix conflicts

a0889dc

vercel bot deployed to Preview – onchainkit-routes April 10, 2025 18:42 View deployment

vercel bot had a problem deploying to Preview – onchainkit-playground April 10, 2025 18:42 Failure

vercel bot had a problem deploying to Preview – onchainkit-coverage April 10, 2025 18:47 Failure

Fix pnpm lockfile

ed0d053

vercel bot deployed to Preview – onchainkit-routes April 10, 2025 19:50 View deployment

vercel bot deployed to Preview – onchainkit-playground April 10, 2025 19:51 View deployment

vercel bot had a problem deploying to Preview – onchainkit-coverage April 10, 2025 19:53 Failure

Merge branch 'main' into danc/swap-packemon-for-vite

2595d67

vercel bot deployed to Preview – onchainkit-routes April 10, 2025 22:19 View deployment

vercel bot deployed to Preview – onchainkit-playground April 10, 2025 22:20 View deployment

vercel bot deployed to Preview – onchainkit-coverage April 10, 2025 22:23 View deployment

Merge branch 'main' into danc/swap-packemon-for-vite

a8e4117

vercel bot deployed to Preview – onchainkit-routes April 11, 2025 19:08 View deployment

vercel bot deployed to Preview – onchainkit-playground April 11, 2025 19:09 View deployment

vercel bot deployed to Preview – onchainkit-coverage April 11, 2025 19:11 View deployment

Rename earn/mocks/index.ts which was causing dev dependencies to be i…

482f7f5

…ncluded in build

vercel bot deployed to Preview – onchainkit-routes April 11, 2025 22:17 View deployment

vercel bot deployed to Preview – onchainkit-playground April 11, 2025 22:18 View deployment

vercel bot had a problem deploying to Preview – onchainkit-coverage April 11, 2025 22:21 Failure

Add dummy test to earn/mocks to pass tests

01890e4

vercel bot deployed to Preview – onchainkit-routes April 11, 2025 22:25 View deployment

vercel bot deployed to Preview – onchainkit-playground April 11, 2025 22:26 View deployment

vercel bot deployed to Preview – onchainkit-coverage April 11, 2025 22:28 View deployment

alessey approved these changes Apr 14, 2025

View reviewed changes

cpcramer approved these changes Apr 14, 2025

View reviewed changes

dgca merged commit 3df178b into main Apr 14, 2025
13 checks passed

dgca deleted the danc/swap-packemon-for-vite branch April 14, 2025 18:22

Dargon789 pushed a commit to Dargon789/onchainkit that referenced this pull request May 26, 2025

refactor: Replace Packemon with Vite (coinbase#2227)

b369057

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: Replace Packemon with Vite #2227

refactor: Replace Packemon with Vite #2227

Uh oh!

dgca commented Apr 4, 2025 •

edited

Loading

Uh oh!

vercel bot commented Apr 4, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

cpcramer commented Apr 7, 2025

Uh oh!

alessey left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

refactor: Replace Packemon with Vite #2227

refactor: Replace Packemon with Vite #2227

Uh oh!

Conversation

dgca commented Apr 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Apr 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

cpcramer commented Apr 7, 2025

Uh oh!

alessey left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

dgca commented Apr 4, 2025 •

edited

Loading

vercel bot commented Apr 4, 2025 •

edited

Loading