Skip to content

Conversation

@Dargon789
Copy link
Owner

What changed? Why?

Notes to reviewers

How has it been tested?

Dargon789 and others added 30 commits April 13, 2025 12:37
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Dan Cortes <3639170+dgca@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
xtbase and others added 11 commits May 27, 2025 00:16
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Dan Cortes <3639170+dgca@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Dan Cortes <3639170+dgca@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Dan Cortes <3639170+dgca@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Dan Cortes <3639170+dgca@users.noreply.github.com>
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @Dargon789, your pull request is larger than the review limit of 150000 diff characters

@snyk-io
Copy link

snyk-io bot commented Dec 15, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Repository owner deleted a comment from vercel bot Dec 15, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on foundational improvements across the project, from setting up continuous integration to modernizing the build pipeline and refining core user-facing features. It streamlines wallet interactions, enhances identity resolution capabilities, and ensures compatibility with evolving web3 standards, all while improving the overall development and user experience.

Highlights

  • Continuous Integration Setup: A new CircleCI configuration file (.circleci/config.yml) has been added, introducing a basic 'say-hello' job and workflow, marking the initial setup for automated testing and deployment processes.
  • Build System Migration: The onchainkit package's build system has been migrated from tsup to vite, indicated by updated package.json scripts and the introduction of vite.config.ts. This change aims to improve build performance and developer experience.
  • Enhanced Recipient State Management: The advanced wallet send feature now utilizes a new useRecipientState hook, centralizing logic for recipient input, validation, and selection, including batch ENS/Basename resolution. This improves the user experience for sending transactions.
  • Dynamic Wagmi Configuration: The DefaultOnchainKitProviders now dynamically creates the Wagmi configuration based on the useOnchainKit context, ensuring the configuration is updated when connectors change. This provides greater flexibility and responsiveness in wallet integration.
  • Farcaster Frame Spec Alignment: The create-onchain templates have been updated to align with the latest Farcaster Frame specification, including new metadata fields and a withValidProperties helper for .well-known/farcaster.json routes.
  • Wallet Modal Customization: The wallet modal now supports a signUpEnabled configuration, allowing developers to control the visibility of the 'Sign up' button, offering more control over the user onboarding flow.
  • Wagmi Experimental Hooks Normalization: New utility functions (normalizeStatus, normalizeTransactionId) have been introduced to handle breaking changes in Wagmi's experimental hooks, ensuring compatibility across different viem versions for transaction status and IDs.
  • Batch Address Resolution: A new useAddresses hook and getAddresses utility have been added to the identity module, enabling efficient batch resolution of multiple ENS names or Basenames to Ethereum addresses.
Ignored Files
  • Ignored by pattern: .github/workflows/** (3)
    • .github/workflows/check.yml
    • .github/workflows/lint.yml
    • .github/workflows/release.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a substantial set of improvements and refactorings across the project. Key changes include migrating the onchainkit package's build system to Vite, which is a great modernization step. The provider architecture has been significantly improved with the refactoring of DefaultOnchainKitProviders, making it more robust and flexible, especially for dynamic configurations. The introduction of batch-processing for ENS/Basename resolution via getAddresses and useAddresses is a significant performance enhancement. I also appreciate the proactive compatibility fixes for wagmi and viem breaking changes and the bug fix for the setTimeout cleanup in SignatureProvider. The state management for the Send component has also been nicely refactored into a dedicated useRecipientState hook. Overall, these are high-quality changes that enhance the project's architecture, performance, and maintainability. I have a couple of suggestions regarding error handling in the new identity utility functions.

@Dargon789 Dargon789 enabled auto-merge (squash) December 15, 2025 06:15
@Dargon789 Dargon789 disabled auto-merge December 15, 2025 08:48
@Dargon789 Dargon789 enabled auto-merge (squash) December 15, 2025 08:48
@vercel
Copy link

vercel bot commented Dec 15, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
my-onchainkit-app Ready Ready Preview, Comment Dec 15, 2025 9:42am
onchainkit-miniapp-manifest-generator Error Error Dec 15, 2025 9:42am

@Dargon789 Dargon789 disabled auto-merge December 15, 2025 09:41
@Dargon789 Dargon789 merged commit c5ca6c2 into main Dec 15, 2025
13 of 23 checks passed
@Dargon789 Dargon789 deleted the circleci-project-setup branch December 15, 2025 09:43
@Dargon789 Dargon789 linked an issue Dec 15, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@coinbase/onchainki wagmi