Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LoginModel cannot use uuid for id column #1044

Closed
wants to merge 2 commits into from
Closed

fix: LoginModel cannot use uuid for id column #1044

wants to merge 2 commits into from

Conversation

MrFrost-Nv27
Copy link
Contributor

@MrFrost-Nv27 MrFrost-Nv27 commented Feb 24, 2024

Description
i want use uuid for user id, so let set the validation customable or change the behavior.

my opinion is for improve jwt token security auth at sub payload not integer id, but uuid

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

i want use uuid for user id, so let set the validation customable or change the behavior.

my opinion is for improve jwt token security auth at sub payload not integer id, but uuid
@kenjis
Copy link
Member

kenjis commented Feb 24, 2024

Please remove the first commit. It will be fixed by #1040

@kenjis kenjis changed the title set loginmodel validation on id column not integer for uuid fix: set loginmodel validation on id column not integer for uuid Feb 24, 2024
@kenjis kenjis added the bug Something isn't working label Feb 24, 2024
@kenjis kenjis changed the title fix: set loginmodel validation on id column not integer for uuid fix: LoginModel cannot use uuid for id column Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants