Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: JWT::loggedIn() does not remove Bearer prefix #1040

Merged
merged 3 commits into from
Feb 24, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Feb 22, 2024

Description
Supersedes #1039 , Close #1039
Fixes #1038

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Something isn't working label Feb 22, 2024
@kenjis kenjis changed the title fix: JWT::loggedIn() does not remove Bearer prefix. fix: JWT::loggedIn() does not remove Bearer prefix Feb 22, 2024
Copy link
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MrFrost-Nv27
Copy link
Contributor

Great! done

@datamweb datamweb merged commit 3fa4ec3 into codeigniter4:develop Feb 24, 2024
33 of 34 checks passed
@datamweb
Copy link
Collaborator

@MrFrost-Nv27 thank you!

@kenjis kenjis deleted the fix-jwt-loggedIn branch February 24, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Bearer prefix on auth header (JWT Authenticator)
3 participants