-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: LoginModel cannot use uuid for id column #1046
Conversation
Thank you, but you missed GPG signing. |
Yes i forget, clear |
@MrFrost-Nv27 Can you use uuid instead of id only with this change? Have you done this practically? |
yes i do, LoginModel user_id get error only on jwt fail with user uuid, i delete integer and all clear, because the minimum scenario (i think) is only let validate the user id is not only integer, string so can be. But, The best way actually change the integer to uuid regex maybe, this the regex ahh sorry, I just meant it. If your intention is to apply UUID to the entire project, including changing the ID from the user table to UUID, that only requires 2 additional steps, namely:
fyi i use the eloquent model hehe 😄 from beginning is start with eloquent service with CI4, this my code to add a user with credential and group UserModel::create([
'username' => 'superadmin',
'nama' => 'Super Admin',
])->setEmailIdentity([
'email' => 'superadmin@gmail.com',
'password' => "password",
])->addGroup('superadmin')->activate(); |
Honestly, I don't agree with the complete removal of the rule and I don't feel good. But it seems that using a regex is a good way. And your branch is currently conflicting, please rebase and fix conflicts. |
Co-authored-by: Pooya Parsa <pooya_parsa_dadashi@yahoo.com>
Description
Supersedes #1044
i want use uuid for user id, so let set the validation customable or change the behavior.
my opinion is for improve jwt token security auth at sub payload not integer id, but uuid
Checklist: