-
Notifications
You must be signed in to change notification settings - Fork 35
Php 5.5.9 ubuntu 14.04 (based on #39) #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is good practice not to use it with Symfony, and this project is small enought that it's unnecessary
Made a strict boolean check for the return value of the Header Preprocessing function
These Controller actions are much bigger than they should be, and so the main logic should go to a Handler. Initial implementation for the 1st one (untelsted)
Moved code to DeletionHandler Service
If the object files dir wasn't opened, opendir echoes a Warning (probably depends on PHP settings), which would break our JSON. Fixed that
…ilation output and added info texts, indicating where the error came from
Reviewed up to dbaa56d |
Added a change that was hardcoded in the compiler production server (performed by kalintiris somewhere back in time).
Added another autocomple-related value that no longer exists in compilation requests, but is hardcoded in the production compiler server.
spiliot
added a commit
that referenced
this pull request
Nov 15, 2015
Php 5.5.9 ubuntu 14.04 (based on #39)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChangeLog
userId_cb_personal_lib
from the compiler error output