Fixes deletion Actions' big size #19
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is good practice not to use it with Symfony, and this project is small enought that it's unnecessary
Made a strict boolean check for the return value of the Header Preprocessing function
tzikis
force-pushed
the
sensiolabs-insight-deletionaction-fixes
branch
from
1b0c40f to
56e638f
Compare
These Controller actions are much bigger than they should be, and so the main logic should go to a Handler. Initial implementation for the 1st one (untelsted)
tzikis
force-pushed
the
sensiolabs-insight-deletionaction-fixes
branch
from
56e638f to
d42172c
Compare
Moved code to DeletionHandler Service
If the object files dir wasn't opened, opendir echoes a Warning (probably depends on PHP settings), which would break our JSON. Fixed that
| $new_code .= "#line 1\n"; | ||
| // Build the new code for the cpp file that will eventually be compiled | ||
| $new_code .= $this->build_code($code, $function_prototypes, $insertion_position); | ||
| $new_code .= "#line 1 \"$filename\"\n"; |
There was a problem hiding this comment.
if, else and foreach without statement included in {} is a really bad idea. How did that pass phpmd?
There was a problem hiding this comment.
PHPMD is not configured in this branch. Going to fix this anyway.
- Added brackets to flow control statements - Replaced upper-case null with lower-case null
- Removed variables passed by reference, made all methods return from a single point - camelCased variables, except for $auth_key, which is already changed on the master branch. - Made braces follow PSR-2 - Removed unnecessary else statements - Changed all double quotes to single quotes in strings
|
Fixed all issues. Closing this PR, will create a new one towards dev branch. PR's based on the master branch are not in accordance to our current workflow |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.