Skip to content

Fixing SensioLabs' Insight warnings to improve the quality of the code #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 25 commits into from
Closed

Fixing SensioLabs' Insight warnings to improve the quality of the code #17

wants to merge 25 commits into from

Conversation

tzikis
Copy link
Member

@tzikis tzikis commented Jan 9, 2015

No description provided.

@tzikis
Copy link
Member Author

tzikis commented Jan 9, 2015

👎 not ready yet

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 6e07cd5 on sensiolabs-insight-fixes into b179e5a on master.

tzikis added 3 commits January 9, 2015 02:21
@tzikis
Replaced OR operator with || & explicit precedence
0f56ce5
@tzikis
Removed unnecessary __FILE__ variables
8a30ae3 
It is good practice not to use it with Symfony, and this project is small enought that it's unnecessary
@tzikis
Added codebender favicon
9aeed6c
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 9aeed6c on sensiolabs-insight-fixes into b179e5a on master.

tzikis added 2 commits January 9, 2015 02:39
@tzikis
Added stricter checks for successful extractions
e25959f
@tzikis
Added stricter checks for successful preprocessing
b332d4a 
Made a strict boolean check for the return value of the Header Preprocessing function
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling b332d4a on sensiolabs-insight-fixes into b179e5a on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-56.06%) when pulling cf132dd on sensiolabs-insight-fixes into b179e5a on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-56.06%) when pulling 01ee571 on sensiolabs-insight-fixes into b179e5a on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.65%) when pulling 7057acc on sensiolabs-insight-fixes into b179e5a on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.65%) when pulling 885857c on sensiolabs-insight-fixes into b179e5a on master.

@tzikis
Copy link
Member Author

tzikis commented Jan 9, 2015

note: coverage not actually increased, just removed the unused Acme Demo bundle, hence the apparent increase in coverage

@coveralls
Copy link

Coverage Status

Coverage increased (+1.47%) when pulling 8b0faee on sensiolabs-insight-fixes into b179e5a on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.54%) when pulling b52fc76 on sensiolabs-insight-fixes into b179e5a on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.54%) when pulling c1b4154 on sensiolabs-insight-fixes into b179e5a on master.

@spiliot spiliot mentioned this pull request Jan 26, 2015
Closed
@fpapadopou
Copy link
Contributor

Closing this PR, going to create a new one towards dev branch in order to merge with several other branches

@fpapadopou fpapadopou closed this Jul 17, 2015
@fpapadopou fpapadopou mentioned this pull request Aug 28, 2015
Merged
@fpapadopou fpapadopou mentioned this pull request Oct 23, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tzikis @coveralls @fpapadopou