Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kvclient/rangefeed: fix rangefeed restart metrics #133947

Merged
merged 1 commit into from
Oct 31, 2024
Merged

kvclient/rangefeed: fix rangefeed restart metrics #133947

merged 1 commit into from
Oct 31, 2024

Conversation

wenyihu6
Copy link
Contributor

@wenyihu6 wenyihu6 commented Oct 31, 2024 •
edited
Loading

Previously, we bump the metrics in restartActiveRangefeed
and again in handleRangefeedError. This patch addresses
the issue of double counting metrics during rangefeed
restarts.

Informs: #129486
Release note: fixed a metrics bug in rangefeed restarts
introduced since v23.2

@blathers-crl blathers[crl]
Copy link

blathers-crl bot commented Oct 31, 2024

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@wenyihu6
kvclient/rangefeed: fix rangefeed restart metrics
e2b7ea7 
Previously, we bump the metrics in restartActiveRangefeed
and again in handleRangefeedError. This patch addresses
the issue of double counting metrics during rangefeed
restarts.

Informs: #129486
Release note: fixed a metrics bug in rangefeed restarts
introduced since v23.2
stevendanna
stevendanna approved these changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@stevendanna stevendanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@wenyihu6 wenyihu6 marked this pull request as ready for review October 31, 2024 13:17
@wenyihu6 wenyihu6 requested a review from a team as a code owner October 31, 2024 13:17
@wenyihu6 wenyihu6 added backport-23.2.x Flags PRs that need to be backported to 23.2. backport-24.1.x Flags PRs that need to be backported to 24.1. backport-24.2.x Flags PRs that need to be backported to 24.2 backport-24.3.x Flags PRs that need to be backported to 24.3 and removed backport-23.2.x Flags PRs that need to be backported to 23.2. backport-24.1.x Flags PRs that need to be backported to 24.1. backport-24.2.x Flags PRs that need to be backported to 24.2 labels Oct 31, 2024
@wenyihu6
Copy link
Contributor Author

TFTR!

bors r=stevendanna

@craig
Copy link
Contributor

craig bot commented Oct 31, 2024

Build succeeded:

@craig craig bot merged commit 8566eaf into master Oct 31, 2024
22 of 23 checks passed
@craig craig bot deleted the metricsfix branch October 31, 2024 17:05
This was referenced Oct 31, 2024
Closed
Open
Open
Open
@yuzefovich yuzefovich removed the backport-23.2.x Flags PRs that need to be backported to 23.2. label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevendanna stevendanna stevendanna approved these changes

Assignees
No one assigned
Labels
backport-24.1.x Flags PRs that need to be backported to 24.1. backport-24.2.x Flags PRs that need to be backported to 24.2 backport-24.3.x Flags PRs that need to be backported to 24.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wenyihu6 @cockroach-teamcity @stevendanna @yuzefovich