-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.2: kvclient/rangefeed: fix rangefeed restart metrics #133975
base: release-23.2
Are you sure you want to change the base?
Conversation
8913894
to
32536ca
Compare
9ae3b3b
to
515e1d1
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Previously, we bump the metrics in restartActiveRangefeed and again in handleRangefeedError. This patch addresses the issue of double counting metrics during rangefeed restarts. Informs: #129486 Release note: fixed a metrics bug in rangefeed restarts introduced since v23.2
515e1d1
to
0fc8b83
Compare
Quick note for reviewer that this was a surgery backport since v23.2 has non-mux rangefeed code. |
Reminder: it has been 3 weeks please merge or close your backport! |
Backport 1/1 commits from #133947 on behalf of @wenyihu6.
/cc @cockroachdb/release
Previously, we bump the metrics in restartActiveRangefeed
and again in handleRangefeedError. This patch addresses
the issue of double counting metrics during rangefeed
restarts.
Informs: #129486
Release note: fixed a metrics bug in rangefeed restarts
introduced since v23.2
Release justification: