Skip to content

Commit

Permalink
Merge #133947
Browse files Browse the repository at this point in the history
133947: kvclient/rangefeed: fix rangefeed restart metrics r=stevendanna a=wenyihu6

Previously, we bump the metrics in restartActiveRangefeed
and again in handleRangefeedError. This patch addresses
the issue of double counting metrics during rangefeed
restarts.

Informs: #129486
Release note: fixed a metrics bug in rangefeed restarts
introduced since v23.2

Co-authored-by: Wenyi Hu <wenyi@cockroachlabs.com>
  • Loading branch information
craig[bot] and wenyihu6 committed Oct 31, 2024
2 parents 21fe75e + e2b7ea7 commit 8566eaf
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions pkg/kv/kvclient/kvcoord/dist_sender_rangefeed.go
Original file line number Diff line number Diff line change
Expand Up @@ -548,8 +548,6 @@ type rangefeedErrorInfo struct {
func handleRangefeedError(
ctx context.Context, metrics *DistSenderRangeFeedMetrics, err error, spawnedFromManualSplit bool,
) (rangefeedErrorInfo, error) {
metrics.Errors.RangefeedRestartRanges.Inc(1)

if err == nil {
return rangefeedErrorInfo{}, nil
}
Expand Down

0 comments on commit 8566eaf

Please sign in to comment.