[miniflare] custom serialization for RegExp object #9454

Enchan1207 · 2025-06-03T14:12:23Z

Summary

add custom serializer for RegExp object.

Problem

vitest can filter test suites that contain non-ascii chars in its name.

test("test suite that contains 日本語", ()=>{
  expect(1).toBe(1)
})

npx vitest -t '日本語' # test suites can be filtered by non-ascii strings

but with vitest-pool-workers, errors are reported:

TypeError: Cannot convert argument to a ByteString because the character at index 1404 has a value of 21336 which is greater than 255.
 ❯ webidl.converters.ByteString ../node_modules/undici/lib/fetch/webidl.js:431:13
 ❯ Object.record<ByteString, ByteString> ../node_modules/undici/lib/fetch/webidl.js:281:28
 ❯ webidl.converters.HeadersInit ../node_modules/undici/lib/fetch/headers.js:579:63
 ❯ Object.RequestInit ../node_modules/undici/lib/fetch/webidl.js:370:17
 ❯ new Request ../node_modules/undici/lib/fetch/request.js:54:30
 ❯ new _Request ../node_modules/@cloudflare/vitest-pool-workers/node_modules/miniflare/dist/src/index.js:1879:5
 ❯ #fetcherFetchCall ../node_modules/@cloudflare/vitest-pool-workers/node_modules/miniflare/dist/src/index.js:12025:21
 ❯ #call ../node_modules/@cloudflare/vitest-pool-workers/node_modules/miniflare/dist/src/index.js:11943:71
 ❯ Proxy.fetch ../node_modules/@cloudflare/vitest-pool-workers/node_modules/miniflare/dist/src/index.js:11933:34
 ❯ runTests ../node_modules/@cloudflare/vitest-pool-workers/dist/pool/index.mjs:1517:26

Cause

it caused by serialization process of devalue.

when option -t (--testNamePattern to be exact) was specified, test pattern strings will be passed as RegExp object (to metadata).

metadatas for tests are passed as request header MF-Vitest-Worker-Data, but devalue operates RegExp object as set of pattern and flags without any encoding.

therefore, when non-ascii chars are included in testNamePattern, it will be passed to request header directly.
request header cannot contain any non-ascii chars, so the problems will be caused.

Solution

added custom reducer/revivers of devalue that encode/decode source strings of RegExp object as base64.

Tests
- TODO (before merge)
- Tests included
- Tests not necessary because:
Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
- I don't know
- Required
- Not required because: vitest is not covered by the e2e tests
Public documentation
- TODO (before merge)
- Cloudflare docs PR(s):
- Documentation not necessary because: it is maybe internal fix
Wrangler V3 Backport
- TODO (before merge)
- Wrangler PR:
- Not necessary because: not a Wrangler change

changeset-bot · 2025-06-03T14:12:31Z

🦋 Changeset detected

Latest commit: 2892b99

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@cloudflare/vitest-pool-workers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

windsurf-bot

Looks good to me 🤙

github-actions · 2025-06-04T09:17:09Z

A Wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15445882788/npm-package-wrangler-9454

Prereleases for other packages:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15445882788/npm-package-cloudflare-workers-bindings-extension-9454 -O ./cloudflare-workers-bindings-extension.0.0.0-vdfd83e32e.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vdfd83e32e.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15445882788/npm-package-create-cloudflare-9454 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15445882788/npm-package-cloudflare-kv-asset-handler-9454

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15445882788/npm-package-miniflare-9454

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15445882788/npm-package-cloudflare-pages-shared-9454

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15445882788/npm-package-cloudflare-unenv-preset-9454

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15445882788/npm-package-cloudflare-vite-plugin-9454

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15445882788/npm-package-cloudflare-vitest-pool-workers-9454

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15445882788/npm-package-cloudflare-workers-editor-shared-9454

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15445882788/npm-package-cloudflare-workers-shared-9454

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15445882788/npm-package-cloudflare-workflows-shared-9454

Note that these links will no longer work once the GitHub Actions artifact expires.

petebacondarwin

Really nice PR - thanks

petebacondarwin · 2025-06-04T10:36:10Z

The CI/TEsts (macOS) job is failing on main so not related to this PR. Once that is fixed we should rebase.

Enchan1207 · 2025-06-04T14:23:42Z

@petebacondarwin

Thank you for approval!
CI problems seem to be resolved by other PR. Should I rebase this?

…cii string

holopin-bot · 2025-06-04T15:42:48Z

Congratulations @Enchan1207, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cmbi49hp8485607jrvkbrbuou

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

This reverts commit 9c30aec.

petebacondarwin · 2025-09-26T14:26:54Z

Sorry this should have been backported to v3

* feat: encode pattern when serialize RegExp object * test: check if test suites can be filtered by pattern includes non-ascii string * chore: remove unneeded comment * test: serialize RegExp object * docs: add changeset for vitest-pool-workers to describe fix

* fix(miniflare): api proxy preserve multiple Set-Cookie headers * [miniflare] custom serialization for RegExp object (#9454) * feat: encode pattern when serialize RegExp object * test: check if test suites can be filtered by pattern includes non-ascii string * chore: remove unneeded comment * test: serialize RegExp object * docs: add changeset for vitest-pool-workers to describe fix --------- Co-authored-by: Calvin Tsang <yuripave@gmail.com> Co-authored-by: Enchan <enchant0130@gmail.com> Co-authored-by: Victor Berchet <victor@suumit.com>

Enchan1207 requested a review from a team as a code owner June 3, 2025 14:12

windsurf-bot bot reviewed Jun 3, 2025

View reviewed changes

workers-devprod added this to workers-sdk Jun 4, 2025

github-project-automation bot moved this to Untriaged in workers-sdk Jun 4, 2025

petebacondarwin approved these changes Jun 4, 2025

View reviewed changes

github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jun 4, 2025

Enchan1207 added 5 commits June 4, 2025 16:08

feat: encode pattern when serialize RegExp object

dda7706

test: check if test suites can be filtered by pattern includes non-as…

35d8cb9

…cii string

chore: remove unneeded comment

fb32dc9

test: serialize RegExp object

06a0966

docs: add changeset for vitest-pool-workers to describe fix

2892b99

petebacondarwin force-pushed the enchan1207/encode-regexp-at-serialize branch from 50c5a85 to 2892b99 Compare June 4, 2025 15:08

petebacondarwin added this pull request to the merge queue Jun 4, 2025

Merged via the queue into cloudflare:main with commit 9c30aec Jun 4, 2025
15 checks passed

github-project-automation bot moved this from Approved to Done in workers-sdk Jun 4, 2025

workers-devprod added the contribution [Holopin] Recognizes an open-source contribution, big or small label Jun 4, 2025

workers-devprod mentioned this pull request Jun 4, 2025

Version Packages #9476

Merged

CarmenPopoviciu added a commit that referenced this pull request Jun 5, 2025

Revert "[miniflare] custom serialization for RegExp object (#9454)"

44afaa4

This reverts commit 9c30aec.

CarmenPopoviciu mentioned this pull request Jun 5, 2025

Revert "[miniflare] custom serialization for RegExp object" #9488

Closed

dario-piotrowicz mentioned this pull request Sep 21, 2025

V3 backport for #9454 and #10683 #10716

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[miniflare] custom serialization for RegExp object #9454

[miniflare] custom serialization for RegExp object #9454

Uh oh!

Enchan1207 commented Jun 3, 2025 •

edited by petebacondarwin

Loading

Uh oh!

changeset-bot bot commented Jun 3, 2025 •

edited

Loading

Uh oh!

windsurf-bot bot left a comment

Uh oh!

github-actions bot commented Jun 4, 2025 •

edited

Loading

Uh oh!

petebacondarwin left a comment

Uh oh!

petebacondarwin commented Jun 4, 2025

Uh oh!

Enchan1207 commented Jun 4, 2025

Uh oh!

Uh oh!

holopin-bot bot commented Jun 4, 2025

Uh oh!

petebacondarwin commented Sep 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[miniflare] custom serialization for RegExp object #9454

[miniflare] custom serialization for RegExp object #9454

Uh oh!

Conversation

Enchan1207 commented Jun 3, 2025 • edited by petebacondarwin Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Problem

Cause

Solution

Uh oh!

changeset-bot bot commented Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

windsurf-bot bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

petebacondarwin left a comment

Choose a reason for hiding this comment

Uh oh!

petebacondarwin commented Jun 4, 2025

Uh oh!

Enchan1207 commented Jun 4, 2025

Uh oh!

Uh oh!

holopin-bot bot commented Jun 4, 2025

Uh oh!

petebacondarwin commented Sep 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Enchan1207 commented Jun 3, 2025 •

edited by petebacondarwin

Loading

changeset-bot bot commented Jun 3, 2025 •

edited

Loading

github-actions bot commented Jun 4, 2025 •

edited

Loading