fix(miniflare): api proxy preserve multiple Set-Cookie headers

[yuripave]

On local service bindings, cross worker RPC will go through miniflare API proxy. Previous implementation of Headers serialization used Object.fromEntries() which works for most cases except when there are multiple Set-Cookie headers (since objects can't have duplicate keys). This PR fixes this by serializing Headers as an array of [key, value] pairs using [...headers.entries()] instead, which preserves all header values including multiple Set-Cookie headers.

---

• Tests
  • Tests included
  • Tests not necessary because:
• Public documentation
  • Cloudflare docs PR(s):
  • Documentation not necessary because: bugfix
• Wrangler V3 Backport
  • Wrangler PR: V3 backport for #9454 and #10683 #10716
  • Not necessary because:

[changeset-bot]

🦋 Changeset detected

Latest commit: 3fd1a64

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages

Name	Type
miniflare	Patch
@cloudflare/pages-shared	Patch
@cloudflare/vite-plugin	Patch
@cloudflare/vitest-pool-workers	Patch
wrangler	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[dario-piotrowicz]

Thanks! This looks fantastic to me @yuripave 🚀 🫶

The only thing missing, could you please add a changeset for this fix? 🙂
(via npx changeset at the root of the repo)

[pkg-pr-new]

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10683

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10683

miniflare

npm i https://pkg.pr.new/miniflare@10683

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10683

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10683

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10683

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10683

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10683

wrangler

npm i https://pkg.pr.new/wrangler@10683

commit: 3fd1a64

[yuripave]

Thanks! This looks fantastic to me @yuripave 🚀 🫶

The only thing missing, could you please add a changeset for this fix? 🙂 (via npx changeset at the root of the repo)

done!

[dario-piotrowicz]

@yuripave I'm really sorry for missing your earlier message, thanks for having pinged me again! 🙇

Again, looks great to me! 😄 with just one very minor final suggestion 🙂

[holopin-bot]

Congratulations @yuripave, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cmg0ujf3u002ml804y9v0alf4

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!