-
Notifications
You must be signed in to change notification settings - Fork 1.1k
V3 backport for #9454 and #10683 #10716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: acac946 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
af84fbe to
bfe25fe
Compare
* feat: encode pattern when serialize RegExp object * test: check if test suites can be filtered by pattern includes non-ascii string * chore: remove unneeded comment * test: serialize RegExp object * docs: add changeset for vitest-pool-workers to describe fix
1c90c00 to
740647a
Compare
|
Note: #9454 didn't include a changeset for the miniflare fix, so for consistency I am also skipping it here, I am happy to add one if we want though |
vicb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Is there any particular reason to include 2 backport PRs in this PR?
If not we should probably avoid as we squash the commits on merge and it would be a pain to revert.
Just for convenience: I don't particularly mind separating the two backports if we strongly prefer that (usually that's also my preference, but since this is a v3 backport I don't really feel strongly either way) |
V3 backport for both #9454 and #10683