Skip to content

Conversation

@dario-piotrowicz
Copy link
Member

@dario-piotrowicz dario-piotrowicz commented Sep 21, 2025

V3 backport for both #9454 and #10683

@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner September 21, 2025 21:40
@dario-piotrowicz dario-piotrowicz added the skip-pr-description-validation Skip validation of the required PR description format label Sep 21, 2025
@changeset-bot
Copy link

changeset-bot bot commented Sep 21, 2025

🦋 Changeset detected

Latest commit: acac946

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
miniflare Patch
@cloudflare/pages-shared Patch
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@petebacondarwin petebacondarwin added the v3-backport The PR is a v3 backport targetting the v3-maintenance branch label Sep 26, 2025
* feat: encode pattern when serialize RegExp object

* test: check if test suites can be filtered by pattern includes non-ascii string

* chore: remove unneeded comment

* test: serialize RegExp object

* docs: add changeset for vitest-pool-workers to describe fix
@dario-piotrowicz dario-piotrowicz changed the title V3 backport #10683 V3 backport for #9454 and #10683 Sep 26, 2025
@dario-piotrowicz
Copy link
Member Author

Note: #9454 didn't include a changeset for the miniflare fix, so for consistency I am also skipping it here, I am happy to add one if we want though

Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Is there any particular reason to include 2 backport PRs in this PR?
If not we should probably avoid as we squash the commits on merge and it would be a pain to revert.

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Sep 29, 2025
@dario-piotrowicz
Copy link
Member Author

Is there any particular reason to include 2 backport PRs in this PR?

Just for convenience:
#10716 (comment)

I don't particularly mind separating the two backports if we strongly prefer that (usually that's also my preference, but since this is a v3 backport I don't really feel strongly either way)

@petebacondarwin petebacondarwin merged commit a879fe0 into v3-maintenance Sep 29, 2025
21 of 22 checks passed
@petebacondarwin petebacondarwin deleted the v3-backport-10683 branch September 29, 2025 18:39
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-pr-description-validation Skip validation of the required PR description format v3-backport The PR is a v3 backport targetting the v3-maintenance branch

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants