add socket attribute to IncomingMessage #4721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlapid
reviewed
Aug 7, 2025
anonrig
force-pushed
the
yagiz/add-http-socket
branch
2 times, most recently
from
bed1bf3 to
bb4362e
Compare
npaun
approved these changes
Aug 7, 2025
jasnell
reviewed
Aug 7, 2025
jasnell
reviewed
Aug 7, 2025
jasnell
approved these changes
Aug 7, 2025
danlapid
reviewed
Aug 7, 2025
danlapid
reviewed
Aug 7, 2025
jasnell
reviewed
Aug 8, 2025
anonrig
force-pushed
the
yagiz/add-http-socket
branch
from
168a3f7 to
8105d76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the missing socket attribute to IncomingMessage. After landing this, we can remove the experimental attribution from the compat flag.