remove experimental attribute from enableNodejsHttpServerModules #4722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
force-pushed
the
yagiz/remove-experimental-http-server
branch
from
951b625 to
6fb561b
Compare
npaun
approved these changes
Aug 7, 2025
danlapid
reviewed
Aug 7, 2025
jasnell
previously approved these changes
Aug 7, 2025
|
Rebased and force pushed. |
jasnell
dismissed
their stale review
Actually, I think there are some improvements that can be done here that would possibly be breaking.... #4734
|
Before removing the experimental flag I'd like us to consider improving the ergonomics of the |
|
Given that we needed to make a few more api changes today that would have been breaking here, I'm inclined to leave this unmerged for at least a few more days. I think things are looking good overall but we should give it a few more days to experiment and review before stamping this complete |
dom96
pushed a commit
that referenced
this pull request
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-requisite to landing this pull-request: #4721
I've tested express.js with cors, Morgan, response-time and compression. It works perfectly.
Relevant documentation change: cloudflare/cloudflare-docs#24268