address pr reviews

Author: anonrig

src/node/internal/internal_http_incoming.ts

@@ -87,7 +87,9 @@ export class IncomingMessage extends Readable implements _IncomingMessage {
     ): void => {
       const connectingIp = headers.get('cf-connecting-ip');
       const isConnectingIpIpv4 = connectingIp ? isIPv4(connectingIp) : true;
-      const remotePort = Math.floor(Math.random() * (65535 - 32768 + 1));
+      // Return a port number between 2^15 and 2^16.
+      const remotePort =
+        Math.floor(Math.random() * (65535 - 32768 + 1)) + 32768;
 
       incoming.#socket = {
         encrypted: headers.get('x-forwarded-proto') === 'https',
@@ -113,11 +115,12 @@ export class IncomingMessage extends Readable implements _IncomingMessage {
         },
         get localPort(): number {
           // This is the port defined by the `server.listen(port)` call.
-          // TODO(soon): Investigate if we should return 443 on production.
           return localPort;
         },
         // Since we don't implement net.Socket, we fallback to IncomingMessage.destroy here.
-        destroy: incoming.destroy.bind(incoming),
+        // We do not use .bind() in case user overwrites destroy method.
+        destroy: (err: Error | undefined): IncomingMessage =>
+          incoming.destroy(err),
       };
     };
   }

src/workerd/api/node/tests/http-server-nodejs-test.js

@@ -1140,6 +1140,8 @@ export const testIncomingMessageSocket = {
       strictEqual(req.socket.localAddress, '127.0.0.1');
       strictEqual(req.socket.remoteAddress, '127.0.0.1');
       strictEqual(typeof req.socket.remotePort, 'number');
+      ok(req.socket.remotePort >= Math.pow(2, 15));
+      ok(req.socket.remotePort <= Math.pow(2, 16));
       strictEqual(req.socket.remoteFamily, 'IPv4');
 
       res.writeHead(200);