Move PojoCloudEventData in core #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
slinkydeveloper
changed the title
slinkydeveloper
added a commit
to slinkydeveloper/sdk-java
that referenced
this pull request
Nov 19, 2020
…events#289 Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Member
Author
|
Related PR #291 |
Contributor
|
I've added some comments, otherwise I think this would be a nice contribution. |
johanhaleby
reviewed
Nov 23, 2020
slinkydeveloper
added a commit
to slinkydeveloper/sdk-java
that referenced
this pull request
Nov 24, 2020
…events#289 Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
slinkydeveloper
added a commit
that referenced
this pull request
Nov 24, 2020
* Add the method `BytesCloudEventData#wrap` to be consistent with #289 Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Removed all usages of constructor Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves
PojoCloudEventDatafrom Jackson in core and generalize it, allowing users to carry their pojos as CloudEvent data.You can use
PojoCloudEventData#wrapto wrap the pojo, together with the marshalling function.For example you can do
PojoCloudEventData.wrap(myPojo, objectMapper::writeValueAsBytes)to wrapmyPojoin aCloudEventData, expliciting theobjectMapper::writeValueAsBytesas the method that will serialize the pojo, if needed, back to bytes.For a sample use case, look at: https://github.com/cloudevents/sdk-java/pull/288/files#diff-d32fb9f764f16209b2cb69f1239b4309975c5601affe825cc4ff9428eca42d1bR64
Signed-off-by: Francesco Guardiani francescoguard@gmail.com